From owner-cvs-src@FreeBSD.ORG  Fri Apr  4 10:22:31 2003
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E428D37B401; Fri,  4 Apr 2003 10:22:30 -0800 (PST)
Received: from HAL9000.homeunix.com (12-233-57-131.client.attbi.com
	[12.233.57.131])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1D1E343FE1; Fri,  4 Apr 2003 10:22:30 -0800 (PST)
	(envelope-from das@FreeBSD.ORG)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	h34IMOKj036758;	Fri, 4 Apr 2003 10:22:24 -0800 (PST)
	(envelope-from das@FreeBSD.ORG)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.6p2/8.12.5/Submit) id h34IMN61036757;
	Fri, 4 Apr 2003 10:22:23 -0800 (PST)
	(envelope-from das@FreeBSD.ORG)
Date: Fri, 4 Apr 2003 10:22:23 -0800
From: David Schultz <das@FreeBSD.ORG>
To: Kris Kennaway <kris@obsecurity.org>
Message-ID: <20030404182223.GA36706@HAL9000.homeunix.com>
Mail-Followup-To: Kris Kennaway <kris@obsecurity.org>,
	Dag-Erling Smorgrav <des@FreeBSD.org>, src-committers@FreeBSD.org,
	cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
References: <200304041729.h34HTtVb027430@repoman.freebsd.org>
	<20030404173635.GA22147@rot13.obsecurity.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030404173635.GA22147@rot13.obsecurity.org>
cc: cvs-src@FreeBSD.ORG
cc: src-committers@FreeBSD.ORG
cc: cvs-all@FreeBSD.ORG
cc: Dag-Erling Smorgrav <des@FreeBSD.ORG>
Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386
	identcpu.c support.s src/sys/i386/include md_var.h src/sys/i386/isa
	npx.c src/sys/ia64/ia64 support.s src/sys/powerpc/powerpc bcopy.c
	src/sys/sparc64/sparc64 support.S ...
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Apr 2003 18:22:31 -0000

Thus spake Kris Kennaway <kris@obsecurity.org>:
> On Fri, Apr 04, 2003 at 09:29:55AM -0800, Dag-Erling Smorgrav wrote:
> 
> >   Define ovbcopy() as a macro which expands to the equivalent bcopy() call,
> >   to take care of the KAME IPv6 code which needs ovbcopy() because NetBSD's
> >   bcopy() doesn't handle overlap like ours.
> 
> Was this for optimization reasons, hysterical raisins, or some other reason?

The ovbcopy-->bcopy conversion doesn't make things any faster or
slower, but it does make some minor optimizations impossible to
implement in the future.  I'm not sure I agree with the changes,
but I don't violently disagree either.

BTW, why does this change convert bcopy from a function pointer to
a function that jumps to the address of a pointer?  This looks
like a net gain in lines of code and a net gain in pipeline
stalls.  Is there something in particular that it makes easier?