Date: Fri, 3 Feb 2012 16:35:37 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Eitan Adler <eadler@freebsd.org> Cc: Daniel Eischen <deischen@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/editors/nedit/files patch-util-misc.c Message-ID: <20120203163537.GA6473@FreeBSD.org> In-Reply-To: <CAF6rxgnoOiiT4KeUf1UA2CziGN2UX_sqrWhqDRvWWAo-tL=mPA@mail.gmail.com> References: <201202030851.q138pWbE025501@repoman.freebsd.org> <CAF6rxgnoOiiT4KeUf1UA2CziGN2UX_sqrWhqDRvWWAo-tL=mPA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 03, 2012 at 10:55:24AM -0500, Eitan Adler wrote: > On Fri, Feb 3, 2012 at 3:51 AM, Daniel Eischen <deischen@freebsd.org> wrote: > > deischen š š2012-02-03 08:51:32 UTC > > > > šAdded files: > > š šeditors/nedit/files špatch-util-misc.c > > šLog: > > šAdd a patch file to prevent nedit from crashing on file->open or > > šfile->save operations. > > Is there a reason this patch has not been committed upstream or is > this temporary until the next release? I concur. While it's very tempting to fix FreeBSD port (especially when it's maintained by you (not you == Daniel, but in general sense)) we should always first contact upstream maintainers/vendor and submit a fix and (at best) ask for review. In case upstream maintainers are not very responsive, but fix is critical or trivial enough, it's OK to fix such port directly, but upstream bug tracker should be filled with detailed bug description and attached patch. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120203163537.GA6473>