From nobody Sat Mar 26 13:29:49 2022 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 9117E1A42F74; Sat, 26 Mar 2022 13:29:51 +0000 (UTC) (envelope-from jrm@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KQfvg3MFtz3HRM; Sat, 26 Mar 2022 13:29:51 +0000 (UTC) (envelope-from jrm@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648301391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9cjUgxdD2uUlszk1osbXrmOprmtt1L7RVTlyaKL25A=; b=LeY6JmjnGseQS5zwcg3FQnDnmJhOIgw65dwqbk1RqCsCGCpmuh309VTIT0QEqDm2ph01We S0kQkzP/A+cQGPCoFI6ybkRBRYgamHaal4ZwsBr6Fy3V3iyf7XlpRxg4cwQ3WcyFQ4efdo eKTK1xl7wErXLrZxl/6jJcNvdCJZeWD4qAkBj4qHIJBROWSjzPQsVgLnPqlSPo7wwDZkeM eofCAlaXp8TGMUreR0u6pwFBreqWCQO90eZA2EphDw+LBeH7zFalJKUkdyH3ljbHkf+pIe IEWVzN9f/lYHJzPY5TWsyNwDcHGuC4Ik0pwkX7b4iz4OLo/FeDl1JrQNiDKpQA== Received: from phe.ftfl.ca.ftfl.ca (drmons0544w-156-34-173-250.dhcp-dynamic.fibreop.ns.bellaliant.net [156.34.173.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: jrm/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 1D47B2A95C; Sat, 26 Mar 2022 13:29:51 +0000 (UTC) (envelope-from jrm@freebsd.org) From: Joseph Mingrone To: Alexey Dokuchaev Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 2b7653e70047 - main - x11-fm/polo: new port had been added (+) References: <202203260111.22Q1B6Km060141@gitrepo.freebsd.org> Date: Sat, 26 Mar 2022 10:29:49 -0300 In-Reply-To: <202203260111.22Q1B6Km060141@gitrepo.freebsd.org> (Alexey Dokuchaev's message of "Sat, 26 Mar 2022 01:11:06 GMT") Message-ID: <86fsn46dv6.fsf@phe.ftfl.ca> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1648301391; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=S9cjUgxdD2uUlszk1osbXrmOprmtt1L7RVTlyaKL25A=; b=X3TLoCFkH/gedlRkb6Uulk9I6vufvGVSFVLsIfnLmz214lK8H3wYpvXpkaXn82882nOiHl to6/9/MHhyl5zCNUIDEoXNH+qoxgpb2br9NK0OkvhVxYILgyy4R+sYG3QoO9xC+RqBDkQi 3GbF3zU8VIBvUc03hVMEjCgbBeKdKw3bN8D8FDmd2qqY/cfP5bZk1cOsHBc2R5MXrY90/b beQn2SkZzkflTusHply1jwcIsRVzcMheE+YmjG9t34Ztwr9AjtN/Ur0UrykajZTQThT9SJ 48aiy0KOdLArnaxy3fCMJy6JBtRGaP+jepPmTkKDUxKoIkarEbsZKhkAQB+E0w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1648301391; a=rsa-sha256; cv=none; b=WqD54knnC3TzL5jaylopGBlAUuyTTtWOwF9ScK1oSc7mYbvkEduLksXH0zYpXImiJLcbWA TKIY5eZsWjuTrgJzinqDxSwBhH3A2tGaaom/rDhXM2Hf29kC/80GOelSzhKCd/BGcb2xn0 GDd6MvJIuDxZRnsS353S19nwIIOSMf4atVEeiXCeRaZma5CcT5Se8Q+sUcwgqw8EBRQY/m hQdOCZWa2YwcQz+8lLduANhYq5TgDwqJ3j0HQMYnJKpm+47dwN1nXqY6Z+NnfDYSteipe0 oEWZaABKkCgKAsCAedkWLTTgnc/HFRmhx/bzQuCh0fcaB3qANz+w6l+q2Wy9rQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Sat, 2022-03-26 at 01:11, Alexey Dokuchaev wrote: > The branch main has been updated by danfe: > URL: https://cgit.FreeBSD.org/ports/commit/?id=3D2b7653e70047152706594137= 3b7f0b9158e33fbd > commit 2b7653e700471527065941373b7f0b9158e33fbd > Author: Alexey Dokuchaev > AuthorDate: 2022-03-26 01:10:00 +0000 > Commit: Alexey Dokuchaev > CommitDate: 2022-03-26 01:10:00 +0000 > x11-fm/polo: new port had been added (+) > Advanced file manager for Unix-like systems written in Vala. Supports > multiple panes (single, dual, quad) with multiple tabs in each pane. > Supports archive creation, extraction, and browsing. Support for clo= ud > storage; running and managing KVM images, modifying PDF documents and > image files, booting ISO files in KVM, writing ISO files to USB drive= s. > WWW: https://teejee2008.github.io/polo/ Is there a good reason to install the binaries unstripped? Stripping them reduces the size by about 20% in this case. If there is a good reason, then '5.16.2. Stripping Binaries and Shared Libraries' of the Porter's Handbook, which says "Installed binaries should be stripped." should be clarified. > diff --git a/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-g= tk-theme b/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-gtk-t= heme > new file mode 100644 > index 000000000000..a174735f961f > --- /dev/null > +++ b/x11-fm/polo/files/patch-share_polo_files_gtk-theme_install-gtk-theme > @@ -0,0 +1,17 @@ > +--- share/polo/files/gtk-theme/install-gtk-theme.orig 2018-08-12 04:41:5= 8 UTC > ++++ share/polo/files/gtk-theme/install-gtk-theme > +@@ -1,4 +1,4 @@ > +-#!/bin/bash > ++#!/bin/sh > +=20 > + gtk_major=3D$( polo-gtk3-helper --major ) > + if [ $? -ne 0 ]; then exit 1; fi > +@@ -11,7 +11,7 @@ DIR=3D"$( cd "$( dirname "$0" )" && pwd )" > + cd $DIR > + if [ $? -ne 0 ]; then exit 1; fi > +=20 > +-if (($gtk_minor =3D=3D 14)) || (($gtk_minor =3D=3D 16)) || (($gtk_minor= =3D=3D 18)) || (($gtk_minor =3D=3D 20)) || (($gtk_minor =3D=3D 22)); then > ++if [ $gtk_minor =3D 14 -o $gtk_minor =3D 16 -o $gtk_minor =3D 18 -o $gt= k_minor =3D 20 -o $gtk_minor =3D 22 ]; then [ .. ] || [ .. ] || .. is a better choice than -o within [ .. ]. See the BUGS section of TEST(1) and https://github.com/koalaman/shellcheck/wiki/SC2166. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKkBAEBCgCOFiEEVbCTpybDiFVxIrrVNqQMg7DW754FAmI/FU1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDU1 QjA5M0E3MjZDMzg4NTU3MTIyQkFENTM2QTQwQzgzQjBENkVGOUUQHGpybUBmcmVl YnNkLm9yZwAKCRA2pAyDsNbvng6aD/9I7MzsIkLLE7EWNWGFTaMRtHZxUX8/zol8 6uyu++hzVBpPQhPgVh34kJz2tgQNPFanZ1kreY1IxQenFUfaEgeMWE0BdlfbEHQX 1/NGc3JvaiJ11GZnpCyoR4jokaHP3hn6XCPZmHw1KNhj9jBDUO2cy3YaW4vRhi06 4/Qz7aDvqnhklbcgN9/t8Neugbpmy5VUoTaSYIo2pr07NsdRsKyJ4tf84+DiLqhA hs+VoeGFCfNs6eKyd1d6R3/fKq9zz84Xzm7RHQp9HLUdWVwmkETzWudAdAu9FMYY lEthk82YR2UldwDdPr9cjb281C7zs0o3Awt3Lmiismx35mXevR5m8V9M6MwHyxuu eA6okT47XB9Chu7f65knWXNL8GoMOA8Id3+0qfO7zdiBUgyQWQeiWagOdMa1y1MY 1p22YH2D/dnhNGHJbpGlpkXVIgZf9Cnhqfi/orbc9SKOxT7LbHZQoLQfdBCwMFwg xWTBZzMqDAHxY0xWBxwG8P5YU+ot9gNSjgZCT2YX8OplRZOXVdzFc42zjNZUcayW C7Oy4gLVVhiOSMwm8YkT0R9I01E+H7ACwsrK764QscxSY0vFJbptXLBmUi1KXW8p vHO0X5DNfKEynQWk5wrhiVgC0IRnz2wDTYKlfuUSiIvm7IkgrKJPu4DhWJhKA+s0 W7U5jT8D+A== =c9sV -----END PGP SIGNATURE----- --=-=-=--