From owner-cvs-ports@FreeBSD.ORG Sat Sep 2 12:45:56 2006 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A93A316A4DF; Sat, 2 Sep 2006 12:45:56 +0000 (UTC) (envelope-from fjoe@neo.samodelkin.net) Received: from neo.samodelkin.net (samodelkin.net [195.62.0.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 22D6E43D46; Sat, 2 Sep 2006 12:45:55 +0000 (GMT) (envelope-from fjoe@neo.samodelkin.net) Received: by neo.samodelkin.net (Postfix, from userid 1000) id 921831705F; Sat, 2 Sep 2006 19:45:53 +0700 (NOVST) Date: Sat, 2 Sep 2006 19:45:53 +0700 From: Max Khon To: G??bor K??vesd??n Message-ID: <20060902124553.GA30093@samodelkin.net> References: <200608041234.k74CYoc1076722@repoman.freebsd.org> <44E389AA.3000003@FreeBSD.org> <44E38E2F.4000005@FreeBSD.org> <44E391AD.3010402@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <44E391AD.3010402@FreeBSD.org> User-Agent: Mutt/1.4.2i Cc: Maxim Sobolev , FreeBSD Developers , cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, Erwin Lansing Subject: Re: cvs commit: ports/Mk bsd.emacs.mk bsd.gnome.mk bsd.mail.mk bsd.openssl.mk bsd.port.mk bsd.port.subdir.mk bsd.python.mk bsd.ruby.mk bsd.scons.mk ports/Tools/scripts security-check.awk ports/databases/p5-DBD-Oracle Makefile ports/databases/p5-sqlrelay ... X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Sep 2006 12:45:56 -0000 Hi! On Wed, Aug 16, 2006 at 11:44:13PM +0200, G??bor K??vesd??n wrote: > >>I think the solution proposed in PR/100555 is overengineered. Why not > >>to build temporary binary package as usually and then use chroot(8) > >>(or -C flag for pkg_install) to install it into DESTDIR environment? > >>This would be *much* simpler approach and it won't require modifying > >>anything but bsd.port.mk. Putting additional load on port maintainers > >>on keeping their ports DESTDIR-clean is too much for such a niche > >>feature. > > > >Just to make clean: what I am proposing is the following course of > >actions when DESTDIR is defined: > > > >1. Build port as usually. Install it as usually. > > > >2. After usual installation is complete build temporary binary package > >out of it and install it into DESTDIR environment. > > > >Automating it would require some amount of work, granted, but it would > >be one time task, not constant burden on port maintainers. > > > >-Maxim > I don't think it would be good, since: > > 1, The package building requires that the package be installed first, > and we don't want to make the host environment dirty in such way. I think this should be fixed. Nobody else requires package to be installed first. /fjoe