From owner-freebsd-bugs@freebsd.org Sun Nov 5 20:06:41 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 47FF5E500E9 for ; Sun, 5 Nov 2017 20:06:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 34FE768A92 for ; Sun, 5 Nov 2017 20:06:41 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vA5K6fIs094020 for ; Sun, 5 Nov 2017 20:06:41 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 223392] [patch] Correct blist_free() comment Date: Sun, 05 Nov 2017 20:06:41 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: alc@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Nov 2017 20:06:41 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223392 --- Comment #2 from Alan Cox --- The comment is not incorrect, but it is poorly written. The word "returned= " is being used to say that the function returns a contiguous range of addresses= to the free pool, not that the function returns anything to the caller. Doug Moore has another round of significant changes to the blist code in the pipeline. See https://reviews.freebsd.org/D12635. I would encourage you to contact him and suggest that he rewrite this comment. The blank lines that your second patch removes are actually required by FreeBSD's style guide. I suspect that the double spaces are eliminated by = Doug Moore's latest change. --=20 You are receiving this mail because: You are the assignee for the bug.=