From owner-freebsd-current@FreeBSD.ORG Mon May 28 05:00:38 2007 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 42BFD16A4E2 for ; Mon, 28 May 2007 05:00:38 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from mrout3.yahoo.com (mrout3.yahoo.com [216.145.54.173]) by mx1.freebsd.org (Postfix) with ESMTP id 3169B13C447 for ; Mon, 28 May 2007 05:00:38 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from minion.local.neville-neil.com (proxy8.corp.yahoo.com [216.145.48.13]) by mrout3.yahoo.com (8.13.6/8.13.6/y.out) with ESMTP id l4S50Gf9070491; Sun, 27 May 2007 22:00:16 -0700 (PDT) Date: Mon, 28 May 2007 11:32:22 +0900 Message-ID: From: gnn@freebsd.org To: Yar Tikhiy In-Reply-To: <20070527115129.GS53113@comp.chem.msu.su> References: <20070527115129.GS53113@comp.chem.msu.su> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.7 Emacs/22.0.95 (i386-apple-darwin8.8.2) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Cc: freebsd-current@freebsd.org Subject: Re: HEADS UP (preliminary): KBI breakage is about to happen X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 May 2007 05:00:38 -0000 At Sun, 27 May 2007 15:51:29 +0400, Yar Tikhiy wrote: > > As discussed earlier on -net, I'd like to commit the following > patch. It will bring ether_ioctl() into accord with ioctl() WRT > the type of the command argument. In our ioctl(), command became > an u_long ages ago, but ether_ioctl() has never been fixed. With > int and u_long being of different widths on 64-bit arch'es, the > discrepancy can get us in trouble sooner or later. > > In fact, ioctl command coding is very unlikely to change, so it > will continue to fit in 32 bits. OTOH, the C compiler should be > uneasy about squeezing u_long into int when ether_ioctl() is called > from an if_ioctl handler, so this patch will be a little step on > the way to a warning-free kernel. > > This change will inevitably break the kernel interface to network > modules, so all of them will need rebuilding. > > Any objections? > Better now than in a few weeks when we branch CURRENT to 7. Best, George