From owner-freebsd-current@freebsd.org Tue Dec 8 15:48:43 2020 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 76E264A3F82 for ; Tue, 8 Dec 2020 15:48:43 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Cr4NB6Brcz4W6X for ; Tue, 8 Dec 2020 15:48:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id D2D554A3B6F; Tue, 8 Dec 2020 15:48:42 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id D29864A3B6E for ; Tue, 8 Dec 2020 15:48:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Cr4NB5QMQz4WDt; Tue, 8 Dec 2020 15:48:42 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x732.google.com with SMTP id w79so5259012qkb.5; Tue, 08 Dec 2020 07:48:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=UoWKQB+UdJ4hm5v2QIy0D5CrMVtgaUQBTHkNw40boAs=; b=VfKc68azJ96wOzC1PwUULgIwV1geRuZeJMiibY/PkRRZ1DtLorgSSFHkfCKEswJtma 1iDK+ElnClI2vniqOWxN2xoeO4TnDS/vHOS9DE5nXlOaplrPevOuex7yS0EsOEIuOWiX q9VlHYsoO1n8yqCTRRYP4dI6iJk24O+4FLXS5IVr+0DS0ThZlySpeynBHzQVAK+WiPFr TRmkvGC/Ka+DRfBZwkigdJfeatA2d71tMKTFbINEw6r4ybjQt1jtxHoGBWUD6sst0D5Z QmJj1xYtA1W5zGduzExsMiH/K97SHBcU58EO66qQvuCrMQEpOlvhwgkDeoAtc8dVBPDd FyOw== X-Gm-Message-State: AOAM532aIM3A8syshB9y2MN6bIWOB5pZgmU+hucy1lpzqicRTgHlApyi YMLic8YFB2KLeOZBa4+fhfKKGKiTxig= X-Google-Smtp-Source: ABdhPJz9p4OQSMHY69prUBDHUuGhNubXBpg4KmftKXNeIonoFweHbAu0KoKiQmKacZwHnSEQlpMLuA== X-Received: by 2002:a05:620a:13a6:: with SMTP id m6mr13269882qki.319.1607442513550; Tue, 08 Dec 2020 07:48:33 -0800 (PST) Received: from raichu ([142.126.164.150]) by smtp.gmail.com with ESMTPSA id 9sm15416338qkm.81.2020.12.08.07.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 07:48:31 -0800 (PST) Sender: Mark Johnston Date: Tue, 8 Dec 2020 10:48:29 -0500 From: Mark Johnston To: Kyle Evans Cc: Peter Holm , current Subject: Re: panic: general protection fault from uipc_sockaddr+0x4c Message-ID: References: <20201208114718.GA33199@x8.osted.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4Cr4NB5QMQz4WDt X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Dec 2020 15:48:43 -0000 On Tue, Dec 08, 2020 at 09:39:05AM -0600, Kyle Evans wrote: > On Tue, Dec 8, 2020 at 9:30 AM Mark Johnston wrote: > > kern_proc_filedesc_out() holds the fdtable shared lock thoughout all of > > this, which is supposed to prevent the table entry from being freed > > since that requires the exclusive lock. > > > > export_file_to_sb drops the lock without it or kern_proc_filedesc_out > holding the file it's about to look at, though. Yes, but that's after it calls fo_fill_kinfo(). At that point it has already collected the to-be-exported info in an sbuf.