From owner-freebsd-bugs@FreeBSD.ORG  Thu Sep 22 09:05:27 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5EEBC106564A;
	Thu, 22 Sep 2011 09:05:27 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 142F88FC12;
	Thu, 22 Sep 2011 09:05:26 +0000 (UTC)
Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63])
	(authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id p8M8vs1A024745
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Thu, 22 Sep 2011 02:57:54 -0600 (MDT) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <201109220755.p8M7t0Vx081424@freefall.freebsd.org>
Date: Thu, 22 Sep 2011 02:57:49 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <25F8136F-8476-4746-91A9-EAADA3C8D20F@bsdimp.com>
References: <201109220755.p8M7t0Vx081424@freefall.freebsd.org>
To: linimon@FreeBSD.org
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Thu, 22 Sep 2011 02:57:54 -0600 (MDT)
Cc: freebsd-bugs@FreeBSD.org, Warner Losh <imp@FreeBSD.org>,
	Garrett Cooper <gcooper@FreeBSD.org>
Subject: Re: conf/160896: [nanobsd] [patch] use getopts, jobs option,
	delay -c usage improvements to nanobsd.sh
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Sep 2011 09:05:27 -0000

Rejecting parts of this patch.  Specifically, the delated -c stuff is =
bogusly implemented.  Before the change, you could have multiple -c =
options on the command line.  after this you can't.

Don't like how -j is implemented in this patch.  Need to think about =
this because it breaks some nanobsd config files that specify NANO_PMAKE =
command.

Other stuff looks good and it, or variations of it, will go in when =
we're out of the freeze.

Warner

On Sep 22, 2011, at 1:55 AM, linimon@FreeBSD.org wrote:

> Old Synopsis: [patch] use getopts, jobs option, delay -c usage =
improvements to nanobsd.sh
> New Synopsis: [nanobsd] [patch] use getopts, jobs option, delay -c =
usage improvements to nanobsd.sh
>=20
> Responsible-Changed-From-To: freebsd-bugs->imp
> Responsible-Changed-By: linimon
> Responsible-Changed-When: Thu Sep 22 07:54:48 UTC 2011
> Responsible-Changed-Why:=20
> Over to maintainer.
>=20
> http://www.freebsd.org/cgi/query-pr.cgi?pr=3D160896
>=20
>=20