From owner-svn-src-all@FreeBSD.ORG Mon Oct 18 21:11:03 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 575A61065672; Mon, 18 Oct 2010 21:11:03 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 23F538FC1A; Mon, 18 Oct 2010 21:11:03 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id C5B5C46B17; Mon, 18 Oct 2010 17:11:02 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id C51A08A009; Mon, 18 Oct 2010 17:11:01 -0400 (EDT) From: John Baldwin To: Rui Paulo Date: Mon, 18 Oct 2010 17:10:14 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201010141919.o9EJJJIc034032@svn.freebsd.org> <96F4E353-55A6-48E6-BA20-92720EC2C4E7@freebsd.org> <201010151628.41177.jhb@freebsd.org> In-Reply-To: <201010151628.41177.jhb@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201010181710.15226.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Mon, 18 Oct 2010 17:11:01 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Dimitry Andric Subject: Re: svn commit: r213845 - head/sys/dev/aic7xxx/aicasm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Oct 2010 21:11:03 -0000 On Friday, October 15, 2010 4:28:40 pm John Baldwin wrote: > On Friday, October 15, 2010 2:50:46 pm Rui Paulo wrote: > > On 15 Oct 2010, at 13:45, John Baldwin wrote: > > > > > On Thursday, October 14, 2010 5:09:58 pm Dimitry Andric wrote: > > >> On 2010-10-14 21:39, John Baldwin wrote: > > >>> On Thursday, October 14, 2010 3:19:19 pm Rui Paulo wrote: > > >> ... > > >>>> Revert r213765. This is required because our build infrastructure uses > > >>>> the host lex instead of the lex built during buildworld. I will MFC the > > >>>> lex changes soon and in a few weeks this I'll commit again r213765. > > >>> Can't you make 'lex' a build-tool to workaround this? > > >> > > >> That will not help for "cd conf/CONF && make kernel", apparently. It > > >> will always use the host lex. > > > > > > Well, yes, but that is always true. build-tools are only used for > > > buildkernel. However, if an 8.x lex cannot build a 9.x kernel, then having > > > lex be a build-tool (or cross-tool, ru@ knows which category better than I) > > > will let a 'make kernel-toolchain' followed by 'make buildkernel' of a 9.x > > > source tree work on an 8.x host. > > > > Yes, but I was told that 'cd conf/CONF && make kernel' is a supported configuration (without requiring kernel-toolchain first). > > Nah, just when it happens to work. It's ok to require people to build a new > world to get a new lex in that case. However, for the buildkernel case the > 'buildworld' / 'toolchain' / 'kernel-toolchain' targets should always build > enough tools to let buildkernel work, so if a new lex is required they should > build a new lex. Untested patch: Index: Makefile.inc1 =================================================================== --- Makefile.inc1 (revision 213841) +++ Makefile.inc1 (working copy) @@ -1088,6 +1090,7 @@ ${_clang} \ gnu/usr.bin/binutils \ gnu/usr.bin/cc \ + usr.bin/lex \ usr.bin/xlint/lint1 usr.bin/xlint/lint2 usr.bin/xlint/xlint \ ${_btxld} \ ${_crunchide} \ -- John Baldwin