From owner-freebsd-atm@FreeBSD.ORG Mon May 29 05:18:13 2006 Return-Path: X-Original-To: freebsd-atm@FreeBSD.org Delivered-To: freebsd-atm@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2614716A50F; Mon, 29 May 2006 05:18:13 +0000 (UTC) (envelope-from kris@obsecurity.org) Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by mx1.FreeBSD.org (Postfix) with ESMTP id D961F43D46; Mon, 29 May 2006 05:18:12 +0000 (GMT) (envelope-from kris@obsecurity.org) Received: from obsecurity.dyndns.org (elvis.mu.org [192.203.228.196]) by elvis.mu.org (Postfix) with ESMTP id A99D61A3C1F; Sun, 28 May 2006 22:18:12 -0700 (PDT) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 11B4D5153E; Mon, 29 May 2006 01:18:12 -0400 (EDT) Date: Mon, 29 May 2006 01:18:11 -0400 From: Kris Kennaway To: gnn@FreeBSD.org Message-ID: <20060529051811.GA60877@xor.obsecurity.org> References: <20060528230058.GA836@lucy.pool-70-17-33-65.pskn.east.verizon.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Cc: freebsd-atm@FreeBSD.org, Robert Watson , freebsd-arch@FreeBSD.org Subject: Re: Locking netatm X-BeenThere: freebsd-atm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ATM for FreeBSD! List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 May 2006 05:18:13 -0000 --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, May 29, 2006 at 01:52:48PM +0900, gnn@FreeBSD.org wrote: > > So my question is, were network interrupts disabled when mucking > > with the atm_timeq list because a generated interrupt can modify > > structures within the list? This use is probably very > > netatm-specific. I'm still studying the timeout code to understand > > what it's doing. > >=20 >=20 > The spl() calls haven't disabled real interrupts, as far as I know, > for quite a while. They acted as general code locks to prevent > simultaneous access to data structures while an update was in > progress. In terms of the timeq, the locks were acting as a mutex now > would to protect the list during an update. Actually the spl calls have all been NOPs since the early 5.0 days, and they were just left in an mnemonic placeholders showing which code/data sections need to be protected. Kris --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEeoQTWry0BWjoQKURAk94AJ41qSIQle1p3QJpxfY+eZ6nrN21jgCeLlvP auY7U0HK7miLNQHDLpfOgMc= =WY96 -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE--