From owner-freebsd-scsi@FreeBSD.ORG Sun Oct 29 05:10:14 2006 Return-Path: X-Original-To: freebsd-scsi@freebsd.org Delivered-To: freebsd-scsi@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8D53116A412 for ; Sun, 29 Oct 2006 05:10:14 +0000 (UTC) (envelope-from lydianconcepts@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id E53B443D45 for ; Sun, 29 Oct 2006 05:10:13 +0000 (GMT) (envelope-from lydianconcepts@gmail.com) Received: by nf-out-0910.google.com with SMTP id p77so1818765nfc for ; Sat, 28 Oct 2006 22:10:12 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=lhOZJU5yVl+7tBRYiKvvPrAbAwCsDBAYtxn1WfVObk+9W2OPHmjM0aEeDAxdm7U17xNDgUvbRiKNw41RhaTEVBMUiG8/UXNq7ib1vwRJxz751pBpOnDGpoA7nV6bdHxmg2prdSoDSfDYS5rxnFgLbekspE6n39t/5LqapcumOrk= Received: by 10.78.166.7 with SMTP id o7mr2525814hue; Sat, 28 Oct 2006 22:10:12 -0700 (PDT) Received: by 10.78.199.15 with HTTP; Sat, 28 Oct 2006 22:10:12 -0700 (PDT) Message-ID: <7579f7fb0610282210p59de2123g379f0d4069bd1e42@mail.gmail.com> Date: Sat, 28 Oct 2006 22:10:12 -0700 From: "Matthew Jacob" To: freebsd-scsi@freebsd.org In-Reply-To: <7579f7fb0610281854l3ec600d7kf0a2cdf20fdcb838@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <7579f7fb0610281854l3ec600d7kf0a2cdf20fdcb838@mail.gmail.com> Subject: Re: CAM_NEW_TRAN- kernel changes ready for review X-BeenThere: freebsd-scsi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SCSI subsystem List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Oct 2006 05:10:14 -0000 This has been updated after I found I'd forgotten to fill in a couple of items (*cough*). On 10/28/06, Matthew Jacob wrote: > http://people.freebsd.org/~mjacob/DIFFS.CAM_NEW_TRAN_CODE > > This covers all the kernel changes. I did not do bug fixing or code > correction while I was at it (with a couple of obvious fixes that were > just glaringly wrong). So, if the > XPT_GET_TRAN_SETTINGS/XPT_SET_TRAN_SETTINGS code in each SIM was not > perfect before, it's still not perfect now. > > This did a LINT+CAM_NEW_TRAN_CODE compile and I'll do some actual h/w > checking too. > > There's a slightly narsty issue with camlib and camcontrol's usage of > XPT_GET_TRAN_SETTINGS- *it* doesn't know about this change. I'm of two > minds about this- whether to just live with the breakage (which will > mean old camcontrol and other users of camlib won't work quite right), > or to make the letdown somewhat gentler by doing a slight reorg of the > new tran_settings structure and the enum for 'type' so that > CAM_NEW_TRAN_CODE will just coincidentally end up with identical usage > to old binaries. > > If all who are interested could, please review this and send comments > back within a couple of days as I don't want this to stall (this is > also a window of time I have for working on this- partly for work in > doing Domain Validation, but also partly because one of my consulting > gigs collapsed and I have a couple of days spare while I'm ramping up > others). >