From nobody Sun Mar 24 12:27:17 2024 X-Original-To: dev-commits-ports-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4V2b1Z1dzSz5FYxv; Sun, 24 Mar 2024 12:27:46 +0000 (UTC) (envelope-from grembo@freebsd.org) Received: from mail.evolve.de (mail.evolve.de [213.239.217.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA512 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mail.evolve.de", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4V2b1Y3Nf2z4kGl; Sun, 24 Mar 2024 12:27:45 +0000 (UTC) (envelope-from grembo@freebsd.org) Authentication-Results: mx1.freebsd.org; none Received: by mail.evolve.de (OpenSMTPD) with ESMTP id 1fe20ed0; Sun, 24 Mar 2024 12:27:36 +0000 (UTC) Received: by mail.evolve.de (OpenSMTPD) with ESMTPSA id c3696763 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 24 Mar 2024 12:27:36 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: Commits to the main branch of the FreeBSD ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-main@freebsd.org X-BeenThere: dev-commits-ports-main@freebsd.org Mime-Version: 1.0 (1.0) Subject: Re: git: d79ba67c4595 - main - devel/phorgeit-arcanist-lib: New port From: Michael Gmelin In-Reply-To: <0984e02f827dea473a52c5b6475aa108@mail.infomaniak.com> Date: Sun, 24 Mar 2024 13:27:17 +0100 Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Message-Id: References: <0984e02f827dea473a52c5b6475aa108@mail.infomaniak.com> To: Daniel Engberg X-Mailer: iPhone Mail (20H320) X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:24940, ipnet:213.239.192.0/18, country:DE] X-Rspamd-Queue-Id: 4V2b1Y3Nf2z4kGl Hi, Thanks for pointing out that I removed that line by accident, fixed. Portversion is because this is the date this port was actually done. The remaining issues will be addressed (if required) asap, definitely before= cutting 2024Q2 (this was based on existing ports and is not perfect yet). I= might fix the existing ports as well while I=E2=80=99m there. Are you wearing any hat or is this due to a personal interest in the quality= of the ports tree (good!) or specifically my commits (which would be weird)= ? Again, thanks for pointing out the removed line, shouldn=E2=80=99t have happ= ened. Cheers > On 24. Mar 2024, at 12:10, Daniel Engberg = wrote: >=20 > =EF=BB=BFHi, >=20 > Why did this remove "- SUBDIR +=3D php-Psr_Log" in devel/Makefile ? >=20 > Please follow Porters Handbook when it comes to versioning and usage of va= riables. >=20 > Commit refers to https://github.com/phorgeit/arcanist/commit/174bf094ef9fe= 26770903c912cf29b6c78760b26 which was committed, Date: Wed, 28 Feb 2024 12:2= 9:14 +0100 >=20 > Why does PORTVERSION say 20240304? > Upstream uses tags so utilize those and do backports of needed unless you n= ever intend to follow upstream, in that case you should use commit date and p= refix g. > See https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-mast= er_sites-github >=20 > Use DISTVERSION whenever possible as shown in examples. please use the sam= e length of commits when using GH_TAGNAME as shown in Porters Handbook. >=20 > Best regards, > Daniel