Date: Tue, 12 Apr 2016 20:02:31 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org>, Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r297902 - head Message-ID: <570DB6C7.6050201@FreeBSD.org> In-Reply-To: <570DB63F.9060907@FreeBSD.org> References: <201604130147.u3D1l5F0032629@repo.freebsd.org> <1460512755.52955.18.camel@freebsd.org> <570DB63F.9060907@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --gchJOQe7LfteundcXeAGjJB9uEWMr31v7 Content-Type: multipart/mixed; boundary="XUfm6KkT5nkCjhN4biLmobjIqORG1itBd" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org>, Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <570DB6C7.6050201@FreeBSD.org> Subject: Re: svn commit: r297902 - head References: <201604130147.u3D1l5F0032629@repo.freebsd.org> <1460512755.52955.18.camel@freebsd.org> <570DB63F.9060907@FreeBSD.org> In-Reply-To: <570DB63F.9060907@FreeBSD.org> --XUfm6KkT5nkCjhN4biLmobjIqORG1itBd Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 4/12/2016 8:00 PM, Steve Wills wrote: > On 04/12/16 09:59 PM, Ian Lepore wrote: >> >> More succinctly: >> >> .if empty(SVN) >> SVN!=3D which svn || which svnlite >> .endif >> >=20 > Fair enough, that's basically the intent. I think we like to avoid !=3D= , > at least in ports, and I wanted the logic between src and ports to matc= h > in this case. >=20 Yeah, please avoid !=3D where possible. If you switch to this then also add .export SVN after the SVN!=3D line. I somewhat like this version more though since /usr/local/bin may not be in the PATH. --=20 Regards, Bryan Drewery --XUfm6KkT5nkCjhN4biLmobjIqORG1itBd-- --gchJOQe7LfteundcXeAGjJB9uEWMr31v7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJXDbbHAAoJEDXXcbtuRpfPRzEIALvR5Las93BHTcguLNM50phD HA5QR4hoy51YK/ciljFs+1ZCzpynH/Zjx+OLIi8V5dU9ZW8LL3xmGo+/UOVG1ilr G7DMhJoAJ4/GI8nIdUTCeE6vrmbJU+CHu7erBqBUbz+FFm1yIAHVOpppoJmagG+Y YMxrr7BdsJ5GE7SqChBxlU4qGAhfdaCdJCopU2rbtTW7/K1I1G8lc+iWX0lP7+qw cXmsEA/0tHUecVZDKwBf74qhtuCfp5J3rZpgH/CmlWpAoCHk5Pvd538TQLiHovey 4RTMYc9Wt9q8D2gB9okAxjFtqhXx6f8lEmPJPeRT9ISC5d38kkg+4YAdaXSVmp0= =H/fW -----END PGP SIGNATURE----- --gchJOQe7LfteundcXeAGjJB9uEWMr31v7--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?570DB6C7.6050201>