From owner-freebsd-bugs Sat Oct 19 15:10: 6 2002 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6441237B404 for ; Sat, 19 Oct 2002 15:10:04 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 05CAD43E4A for ; Sat, 19 Oct 2002 15:10:02 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.6/8.12.6) with ESMTP id g9JMA1x3061065 for ; Sat, 19 Oct 2002 15:10:01 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.6/8.12.6/Submit) id g9JMA1bE061064; Sat, 19 Oct 2002 15:10:01 -0700 (PDT) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 93B3137B404 for ; Sat, 19 Oct 2002 15:00:27 -0700 (PDT) Received: from guardian.sch.ru (TCH-MSU.ATM6-0.181.M9-R1.msu.net [212.16.0.250]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8DA5743E9C for ; Sat, 19 Oct 2002 15:00:25 -0700 (PDT) (envelope-from mokr@amber.mokr.ru) Received: from amber.mokr.ru ([172.16.0.6]) by guardian.sch.ru (8.12.6/8.12.6/20021009101427) with ESMTP id g9JM0OeA045091 for ; Sun, 20 Oct 2002 02:00:24 +0400 (MSD) (envelope-from mokr@amber.mokr.ru) Received: from amber.mokr.ru (localhost [127.0.0.1]) by amber.mokr.ru (8.12.6/8.12.6/020822) with ESMTP id g9JLxrCA001055 for ; Sun, 20 Oct 2002 02:00:24 +0400 (MSD) (envelope-from mokr@amber.mokr.ru) Received: (from mokr@localhost) by amber.mokr.ru (8.12.6/8.12.6/Submit) id g9JLxrYE001054; Sun, 20 Oct 2002 01:59:53 +0400 (MSD) Message-Id: <200210192159.g9JLxrYE001054@amber.mokr.ru> Date: Sun, 20 Oct 2002 01:59:53 +0400 (MSD) From: Sergey Mokryshev Reply-To: Sergey Mokryshev To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: misc/44284: /etc/rc.d/ipnat does not properly call 'err' in absense of ipfilter module Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org >Number: 44284 >Category: misc >Synopsis: /etc/rc.d/ipnat does not properly call 'err' in absense of ipfilter module >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Oct 19 15:10:01 PDT 2002 >Closed-Date: >Last-Modified: >Originator: Sergey Mokryshev >Release: FreeBSD 5.0-CURRENT i386 >Organization: Tersys >Environment: System: FreeBSD amber.mokr.net 5.0-CURRENT FreeBSD 5.0-CURRENT #12: Sun Oct 20 00:40:36 MSD 2002 su@amber.mokr.net:/.1/a/obj/.1/a/src/sys/AMBER_UP i386 >Description: /etc/rc.d/ipnat miss first argument (error code) while calling 'err' routine from /etc/rc.subr >How-To-Repeat: echo 'ipfilter_enable="NO"' >>/etc/rc.conf echo 'ipnat_enable="YES"' >>/etc/rc.conf (remove options IPFILTER from kernel configuration if it is there and recompile kernel) reboot examine console output, there should be Oct 20 01:05:11 amber kernel: /etc/rc: ERROR: Oct 20 01:05:11 amber kernel: exit: Illegal number: ipnat >Fix: --- /tmp/ipnat.orig Sun Oct 20 01:29:50 2002 +++ ipnat Sun Oct 20 01:32:55 2002 @@ -36,8 +36,7 @@ { # Make sure ipfilter is loaded before continuing if ! ${SYSCTL} net.inet.ipf.fr_pass >/dev/null 2>&1; then - err 'ipnat requires ipfilter be loaded' - return 1 + err 1 'ipnat requires ipfilter be loaded' fi return 0 } >Release-Note: >Audit-Trail: >Unformatted: To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message