From owner-svn-src-head@FreeBSD.ORG Fri Dec 10 16:52:40 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48D35106566C; Fri, 10 Dec 2010 16:52:40 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 198228FC13; Fri, 10 Dec 2010 16:52:40 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id A741446B03; Fri, 10 Dec 2010 11:52:39 -0500 (EST) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 817C98A01D; Fri, 10 Dec 2010 11:52:38 -0500 (EST) From: John Baldwin To: Tijl Coosemans Date: Fri, 10 Dec 2010 11:52:24 -0500 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; ) References: <201012101505.oBAF5n9X077454@svn.freebsd.org> <201012101031.36641.jhb@freebsd.org> <201012101736.25488.tijl@freebsd.org> In-Reply-To: <201012101736.25488.tijl@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201012101152.24843.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6 (bigwig.baldwin.cx); Fri, 10 Dec 2010 11:52:38 -0500 (EST) X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r216358 - head/sys/dev/le X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Dec 2010 16:52:40 -0000 On Friday, December 10, 2010 11:36:17 am Tijl Coosemans wrote: > On Friday 10 December 2010 16:31:36 John Baldwin wrote: > > On Friday, December 10, 2010 10:05:49 am Tijl Coosemans wrote: > >> Author: tijl > >> Date: Fri Dec 10 15:05:49 2010 > >> New Revision: 216358 > >> URL: http://svn.freebsd.org/changeset/base/216358 > >> > >> Log: > >> Use SYS_RES_IOPORT instead of PCIM_CMD_PORTEN when calling pci_enable_io. > >> > >> Approved by: kib (mentor) > > > > To be honest, bus_alloc_resource() with RF_ACTIVE will set PORTEN or MEMEN for > > you. Drivers should no longer be calling pci_enable_io() by hand. > > Looking into this, in dev/sound/pci/atiixp.c and dev/sound/pci/ich.c it > is used during resume. Can those calls be removed as well? Yes, we save and restore the command register (along with other standard header registers like BARs, etc.) across suspend and resume in the PCI bus layer. > And in dev/mpt/mpt.c pci_enable_io and pci_disable_io are called in a > number of places. Those should probably all stay? Yes, that appears to be a workaround for a quirk in the hardware. -- John Baldwin