From owner-freebsd-ports@FreeBSD.ORG Sat Jul 21 20:48:09 2012 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 5F2AA1065670; Sat, 21 Jul 2012 20:48:09 +0000 (UTC) (envelope-from bsdkaffee@gmail.com) Received: from mail-vb0-f54.google.com (mail-vb0-f54.google.com [209.85.212.54]) by mx1.freebsd.org (Postfix) with ESMTP id AED2C8FC0A; Sat, 21 Jul 2012 20:48:08 +0000 (UTC) Received: by vbmv11 with SMTP id v11so4722026vbm.13 for ; Sat, 21 Jul 2012 13:48:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding:content-type; bh=/ketZdF0gD2jQfFA1gEYoJgzJGfDmACEFrRwnJor2+0=; b=AlpzV7Rm6rL5QmACreGOw1isZmKlMSNjY42J0aweN7nlZL5bW/e6AvGzkI75bwkQNt eoW3wPzwzim8gYB6ghxi0KJsUR/AEr3N77yru+dh9z7apzFGQocV+zT2hJTbP7TvXcgi S4AuBtG3sNN515Sgok7Y27vmQftWJptAtKhYKH2EELGSpTwjUisLj73FnMExXtmMZXjs 5awSHNFoIwpVsU9nPE/Ip1wv4XvgLB4NAadv42vw/OuRlNG6UnzxntPdXs3OO+ooKocb C5HPM2B5rzWgYIwwJb9E7+OMYzsFmYNPXiJlp9We/ca0W4kWOtx4beeVlbG2ijtnIB/q 5DlQ== Received: by 10.52.72.44 with SMTP id a12mr7138584vdv.124.1342903682404; Sat, 21 Jul 2012 13:48:02 -0700 (PDT) Received: from mocha.verizon.net (c-71-61-40-68.hsd1.oh.comcast.net. [71.61.40.68]) by mx.google.com with ESMTPS id d3sm3025410vdi.13.2012.07.21.13.48.01 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 21 Jul 2012 13:48:01 -0700 (PDT) From: "Jason E. Hale" To: Scot Hetzel Date: Sat, 21 Jul 2012 13:48:01 -0700 (PDT) Message-ID: <2193820.CL19acAFmS@mocha.verizon.net> User-Agent: KMail/4.8.4 (FreeBSD/9.0-RELEASE-p3; KDE/4.8.4; i386; ; ) In-Reply-To: References: <15617903.FBMimp13fy@mocha.verizon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: Doug Barton , Jeremy Messenger , ruby@freebsd.org, Edwin Groothuis , freebsd-ports@freebsd.org, gnome@freebsd.org, johans@freebsd.org Subject: Re: How to remove erroneous deps from pkgng X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jul 2012 20:48:09 -0000 On Saturday, July 21, 2012 11:38:39 Scot Hetzel wrote: > > The problem with simply removing > > > > pkgconfig_RUN_DEPENDS= pkg-config:${PORTSDIR}/devel/pkg-config > > > > from bsd.gnome.mk is that there are ports that indirectly depend on > > pkg-config for their build through other ports that directly depend on it > > since it has just been a runtime dependency. I know there are quite a > > few KDE ports like that. > > Removing this runtime dependency for pkgconfig from bsd.gnome.mk is > the correct thing to do, until we have the better frame work to > specify that pkgconfig is a build or run dependancy. > IMO I don't really see what the hurry is. This has been the behavior for years. I think we can wait until there is a framework in place so we are not doing double work. I agree it should be done, but why go through all this again in a week or a month? > > To explain better, x11/kdelibs4 has USE_GNOME=pkgconfig, but some ports > > that depend on kdelibs4 and require pkg-config for their build are not > > currently defining USE_GNOME=pkgconfig since it is assumed that > > pkg-config is installed. A direct dependency for pkg-config would need to > > be added to all of those ports. > > That is what the experimental run will tell us. Which ports break > when this line is removed/disabled in bsd.gnome.mk. This way we can > fix those ports by adding a BUILD_DEPENDS to them. > There are a few ports that need pkg-config to properly configure, but will build anyways without it. Just doing an exp-run isn't going to neccessarily test for those (graphics/kipi-plugins-kde4 is a good example although in that case there may be some file leftovers to give it away). Certain non-default options may use pkg-config to check a dependency as well and a default build wouldn't tell us if those options worked or not. > > I think there would be a lot less breakage if the line in bsd.gnome.mk > > were > > left in for now and we migrated over to the pkgconfig:build/run scheme. > > We would still have the same amount of breakage. In your example > x11/kdelibs4 would be changed to USE_GNOME=pkgconfig:build. The ports > that still have an indirect build dependancy on pkgconfig would still > fail to build. > I see what you're saying. I was originally thinking that it would still remain as USE_GNOME=pkgconfig, meaning pkg-config is a build and run dependency and we could opt-in to either :build or :run later. My main concern is with ports like graphics/kipi-plugins-kde4 where the failure isn't going to be as obvious. I think a good alternative is to detect the ports that currently have and indirect dependency on pkg-config whether needed or not and add USE_GNOME=pkgconfig (if we are just going to remove the line from bsd.gnome.mk) to them for now. Jason E. Hale KDE/FreeBSD Team