From owner-p4-projects@FreeBSD.ORG  Sun Sep 21 13:52:30 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B03A31065687; Sun, 21 Sep 2008 13:52:30 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 75EE0106567B
	for <perforce@FreeBSD.org>; Sun, 21 Sep 2008 13:52:30 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 6541D8FC15
	for <perforce@FreeBSD.org>; Sun, 21 Sep 2008 13:52:30 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id m8LDqUtj035320
	for <perforce@FreeBSD.org>; Sun, 21 Sep 2008 13:52:30 GMT
	(envelope-from ed@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id m8LDqUnJ035314
	for perforce@freebsd.org; Sun, 21 Sep 2008 13:52:30 GMT
	(envelope-from ed@FreeBSD.org)
Date: Sun, 21 Sep 2008 13:52:30 GMT
Message-Id: <200809211352.m8LDqUnJ035314@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	ed@FreeBSD.org using -f
From: Ed Schouten <ed@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 150204 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Sep 2008 13:52:30 -0000

http://perforce.freebsd.org/chv.cgi?CH=150204

Change 150204 by ed@ed_dull on 2008/09/21 13:52:23

	As discussed with kib@, move the vfs_timestamp call to
	devfs_alloc, where it doesn't pick up any locks.

Affected files ...

.. //depot/projects/mpsafetty/sys/fs/devfs/devfs_devs.c#2 edit
.. //depot/projects/mpsafetty/sys/kern/kern_conf.c#5 edit

Differences ...

==== //depot/projects/mpsafetty/sys/fs/devfs/devfs_devs.c#2 (text+ko) ====

@@ -117,6 +117,7 @@
 {
 	struct cdev_priv *cdp;
 	struct cdev *cdev;
+	struct timespec ts;
 
 	cdp = malloc(sizeof *cdp, M_CDEVP, M_USE_RESERVE | M_ZERO | M_WAITOK);
 
@@ -128,6 +129,9 @@
 
 	cdev->si_name = cdev->__si_namebuf;
 	LIST_INIT(&cdev->si_children);
+	vfs_timestamp(&ts);
+	cdev->si_atime = cdev->si_mtime = cdev->si_ctime = ts;
+
 	return (cdev);
 }
 

==== //depot/projects/mpsafetty/sys/kern/kern_conf.c#5 (text+ko) ====

@@ -526,7 +526,6 @@
 newdev(struct cdevsw *csw, int y, struct cdev *si)
 {
 	struct cdev *si2;
-	struct timespec ts;
 	dev_t	udev;
 
 	mtx_assert(&devmtx, MA_OWNED);
@@ -542,10 +541,6 @@
 	}
 	si->si_drv0 = udev;
 	si->si_devsw = csw;
-
-	vfs_timestamp(&ts);
-	si->si_atime = si->si_mtime = si->si_ctime = ts;
-
 	LIST_INSERT_HEAD(&csw->d_devs, si, si_list);
 	return (si);
 }