From owner-cvs-src@FreeBSD.ORG  Sat Dec  1 00:16:40 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A4FF716A41A
	for <cvs-src@freebsd.org>; Sat,  1 Dec 2007 00:16:40 +0000 (UTC)
	(envelope-from zec@imunes.net)
Received: from zec2.tel.fer.hr (zec2.tel.fer.hr [161.53.19.79])
	by mx1.freebsd.org (Postfix) with ESMTP id 343E413C465
	for <cvs-src@freebsd.org>; Sat,  1 Dec 2007 00:16:39 +0000 (UTC)
	(envelope-from zec@imunes.net)
Received: from localhost (localhost [127.0.0.1])
	by zec2.tel.fer.hr (8.14.1/8.14.1) with ESMTP id lB101xVG001374
	for <cvs-src@freebsd.org>; Sat, 1 Dec 2007 01:01:59 +0100 (CET)
	(envelope-from zec@imunes.net)
From: Marko Zec <zec@imunes.net>
To: cvs-src@freebsd.org
Date: Sat, 1 Dec 2007 01:01:58 +0100
User-Agent: KMail/1.9.7
References: <200711302327.lAUNRdV9025350@repoman.freebsd.org>
	<20071130233148.Y53707@maildrop.int.zabbadoz.net>
In-Reply-To: <20071130233148.Y53707@maildrop.int.zabbadoz.net>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200712010101.59111.zec@imunes.net>
Subject: Re: cvs commit: src/sys/netgraph ng_cisco.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 01 Dec 2007 00:16:40 -0000

On Saturday 01 December 2007 00:34:51 Bjoern A. Zeeb wrote:
> On Fri, 30 Nov 2007, Julian Elischer wrote:
> > julian      2007-11-30 23:27:39 UTC
> >
> >  FreeBSD src repository
> >
> >  Modified files:
> >    sys/netgraph         ng_cisco.c
> >  Log:
> >  Add ipv6 to ng_cisco node. ipv6 wasn't a reality when I wrote it..
>
> It only hit the FreeBSD tree about 1 month earlier than in6.c did;-)
>
> I wonder if that should be #ifdef INET6 or what happens for people
> not haveing INET6 support in but still being able to configure it?

ng_cisco is a pure netgraph node, it only muxes/demuxes data from one 
HDLC to many protocol-specific hooks and vice versa, i.e. it doesn't 
interact with protocol-specific code in the network stack at all - that 
happens in ng_iface to which ng_cisco nodes typically connect to.  
There's no need / place for #ifdef INET6 in ng_cisco.

Marko