From owner-svn-src-all@freebsd.org Wed Oct 31 14:52:41 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 73E5510DC308 for ; Wed, 31 Oct 2018 14:52:41 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1a.eu.mailhop.org (outbound1a.eu.mailhop.org [52.58.109.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E554D79508 for ; Wed, 31 Oct 2018 14:52:40 +0000 (UTC) (envelope-from ian@freebsd.org) ARC-Seal: i=1; a=rsa-sha256; t=1540997552; cv=none; d=outbound.mailhop.org; s=arc-outbound20181012; b=eF4F8zvbTSDOSI2n6rocJCcr25scG1wNLP8dTatqoBwMmlc7rcc0XEX/5ajeT3Z/+k7YTxYl0KCit W0E6koi+w9Uo+85zUJkAJLCG/CCJpbvU7+3uMkNz43j3+QB8EJszH0h+GQ/O3lKzqmO/zXbstlKWiT QcuAosAHFkVMZfWZZxkUubS1BKJEl9FEZzRBarWJg7ttCV1pWDm+M3ZYex+a/+H3ZOCSFROnGBtqho MReAfbxSADLFuM+N45L56exckqN/rXe2IltaVasuywEtlC++6KnBlYhWGutMuafNONwCRnspKumde2 H77joG/jMIueoEwvKi2xUynxDqmWJAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=arc-outbound20181012; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:dkim-signature:from; bh=Hd1Awmkuu0I/S+5TgXlK4bgsIZerGKumy4sOuOUii7U=; b=isHG5iTA4FSCZZfnGPFiMRhVSLcP9GGOOiHNOu50EQViGZpNI8ej/CLotY5qqECNCEuTRfpcHE02Q rgvIUB+WXN4MTVhaG7m3/qNA0PEfmN8q92UQ8QugW6NivzHiUBQy8App+Hcf9EsfGTcoJ7CFfDO6An 11J6ZHfAsxJgNE96a9FEIfa3FNMimWe2aFX9L1QLw7qP1rvz1PrT+tPc2nt/PV4yOuCNFqugijvxVK vGVStdmmUhkPC1ZIxvEXuyPuzJi+T+NOFzngSahGWT9pzcz6qiQgZLu1MwxIaD1mtcmjFhVZ5VFn1Q FA8pk7r0g6+jUvDc7IX80NHD4ZFtyDg== ARC-Authentication-Results: i=1; outbound1.eu.mailhop.org; spf=softfail smtp.mailfrom=freebsd.org smtp.remote-ip=67.177.211.60; dmarc=none header.from=freebsd.org; arc=none header.oldest-pass=0; DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outbound.mailhop.org; s=dkim-high; h=content-transfer-encoding:mime-version:content-type:references:in-reply-to: date:cc:to:from:subject:message-id:from; bh=Hd1Awmkuu0I/S+5TgXlK4bgsIZerGKumy4sOuOUii7U=; b=HU9T5YX/qJnk4WMf5mBIpuFeUMlXjFWCDc/ZPVJVhYTA+qBuiAVEJ4LX5ZdIyzF3gCs9i0TFg5Cbr YQYpRdyZJMdDjRvBG9AwFlAl1FDuvLU3AtRnA/uIxf+DuU8s9XM9BDBzvx8hv9ey0dKJVrhLkN2mfV ezpQGts0OuSuYJEDCCjAnIilW/97kMzT0FgL/v+FdioERTSFGmvEVCI9/qjLVK+Pw/pdn7oP5//ok9 DFgaGb6GZZohABySC/F0prJSxBlF3G99dSXW6lBjShHZDaIVPIgVcbK3CIcQHdpQ0/GTXMwnVeo24X gAV3cFSlCzChlGC6Wtkyrrb2Q8e0aOw== X-MHO-RoutePath: aGlwcGll X-MHO-User: 9273fc5f-dd1c-11e8-9048-075f73944867 X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound1.eu.mailhop.org (Halon) with ESMTPSA id 9273fc5f-dd1c-11e8-9048-075f73944867; Wed, 31 Oct 2018 14:52:27 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w9VEqLRV067365; Wed, 31 Oct 2018 08:52:21 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1540997541.22340.165.camel@freebsd.org> Subject: Re: svn commit: r339936 - head/sys/amd64/vmm/amd From: Ian Lepore To: Shawn Webb , Marcelo Araujo Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Wed, 31 Oct 2018 08:52:21 -0600 In-Reply-To: <20181031140631.ipwlwh3rlm7ma4xk@mutt-hbsd> References: <201810310127.w9V1RiFX025463@repo.freebsd.org> <20181031140631.ipwlwh3rlm7ma4xk@mutt-hbsd> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Oct 2018 14:52:41 -0000 On Wed, 2018-10-31 at 10:06 -0400, Shawn Webb wrote: > On Wed, Oct 31, 2018 at 01:27:44AM +0000, Marcelo Araujo wrote: > > > > Author: araujo > > Date: Wed Oct 31 01:27:44 2018 > > New Revision: 339936 > > URL: https://svnweb.freebsd.org/changeset/base/339936 > > > > Log: > >   Merge cases with upper block. > >   This is a cosmetic change only to simplify code. > >    > >   Reported by: anish > >   Sponsored by: iXsystems Inc. > > > > Modified: > >   head/sys/amd64/vmm/amd/svm_msr.c > > > > Modified: head/sys/amd64/vmm/amd/svm_msr.c > > =================================================================== > > =========== > > --- head/sys/amd64/vmm/amd/svm_msr.c Tue Oct 30 23:09:04 > > 2018 (r339935) > > +++ head/sys/amd64/vmm/amd/svm_msr.c Wed Oct 31 01:27:44 > > 2018 (r339936) > > @@ -122,11 +122,7 @@ svm_rdmsr(struct svm_softc *sc, int vcpu, > > u_int num, u > >   case MSR_MTRR16kBase ... MSR_MTRR16kBase + 1: > >   case MSR_MTRR64kBase: > >   case MSR_SYSCFG: > > - *result = 0; > > - break; > >   case MSR_AMDK8_IPM: > > - *result = 0; > > - break; > >   case MSR_EXTFEATURES: > >   *result = 0; > >   break; > Does this need a /* FALLTHROUGH */ comment to appease the Coverity > Gods? > > Thanks, > I would hope not, stacking multiple case values together is a common technique that almost never indicates a coding accident. The fall- through warning should only get triggered when there is executable code without a break between the various case values.  Good:    case 1:    case 2:        code();        break;  Warning:    case 1:        code();    case 2:        morecode();        break; -- Ian