Date: Sun, 27 Mar 2022 01:12:50 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Joseph Mingrone <jrm@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 2b7653e70047 - main - x11-fm/polo: new port had been added (+) Message-ID: <Yj%2B6Er4vFWKgE0Dd@FreeBSD.org> In-Reply-To: <86fsn46dv6.fsf@phe.ftfl.ca> References: <202203260111.22Q1B6Km060141@gitrepo.freebsd.org> <86fsn46dv6.fsf@phe.ftfl.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Mar 26, 2022 at 10:29:49AM -0300, Joseph Mingrone wrote: > Is there a good reason to install the binaries unstripped? No, can't think of one. > > +-if (($gtk_minor == 14)) || (($gtk_minor == 16)) || (($gtk_minor == 18)) || (($gtk_minor == 20)) || (($gtk_minor == 22)); then > > ++if [ $gtk_minor = 14 -o $gtk_minor = 16 -o $gtk_minor = 18 -o $gtk_minor = 20 -o $gtk_minor = 22 ]; then > > [ .. ] || [ .. ] || .. is a better choice than -o within [ .. ]. See > the BUGS section of TEST(1) and > https://github.com/koalaman/shellcheck/wiki/SC2166. Interesting. Basically, it says "-a and -o are not well defined and can cause incorrect results when arguments start with dashes or contain !". Unfortunately it does not provide example of such breakage. Personally I like -o better than chainin of several test(1) calls, and since there are definitely no dashes or !'s involved here we should be fine. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Yj%2B6Er4vFWKgE0Dd>