From owner-freebsd-hackers@freebsd.org Fri May 20 11:34:35 2016 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DD53FB43D67 for ; Fri, 20 May 2016 11:34:35 +0000 (UTC) (envelope-from lars@e-new.0x20.net) Received: from mail.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.0x20.net", Issuer "mail.0x20.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id A53511776; Fri, 20 May 2016 11:34:35 +0000 (UTC) (envelope-from lars@e-new.0x20.net) Received: from e-new.0x20.net (mail.0x20.net [IPv6:2001:aa8:fffb:1::3]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.0x20.net (Postfix) with ESMTPS id 0F4B26E0081; Fri, 20 May 2016 13:34:33 +0200 (CEST) Received: from e-new.0x20.net (localhost [127.0.0.1]) by e-new.0x20.net (8.14.7/8.14.7) with ESMTP id u4KBYWJd089237; Fri, 20 May 2016 13:34:32 +0200 (CEST) (envelope-from lars@e-new.0x20.net) Received: (from lars@localhost) by e-new.0x20.net (8.14.7/8.14.7/Submit) id u4KBYWvW088869; Fri, 20 May 2016 13:34:32 +0200 (CEST) (envelope-from lars) Date: Fri, 20 May 2016 13:34:32 +0200 From: Lars Engels To: Damien Fleuriot Cc: freebsd-hackers@freebsd.org, Randy Westlund , Allan Jude Subject: Re: What changes are welcome? Message-ID: <20160520113431.GW15808@e-new.0x20.net> References: <20160519041118.GE19887@gmail.com> <573D3DA7.20600@freebsd.org> <20160519212934.GF19887@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="+rRWuC8ZLvVekNoN" Content-Disposition: inline In-Reply-To: X-Editor: VIM - Vi IMproved 7.4 X-Operation-System: FreeBSD 8.4-RELEASE-p23 User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 May 2016 11:34:36 -0000 --+rRWuC8ZLvVekNoN Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 20, 2016 at 12:53:36PM +0200, Damien Fleuriot wrote: > On 19 May 2016 at 23:29, Randy Westlund wrote: >=20 > > On Thu, May 19, 2016 at 12:14:31AM -0400, Allan Jude wrote: > > > Generally, you likely want to avoid changing anything from contrib/ or > > > vendor/, as that is code from other projects that is imported, and lo= cal > > > changes complicate that. Of course, top is not really maintained > > > 'upstream' anymore, so maybe it isn't a bad place to start. > > > > > > Phabricator is likely the best place for patches, it is much easier to > > > review. > > > > Indeed, looks like it's been 16 years. I silenced 131 warnings. > > > > https://reviews.freebsd.org/D6468 > > >=20 >=20 > Sorry for hijacking ;) >=20 >=20 >=20 > On the topic of contributing, there's a bug report I filed almost a year > ago for net/relayd [1] >=20 > The submitted change is very minor and mimics nginx's behaviour, adding a > configuration sanity check before restarting or reloading net/relayd. >=20 >=20 > Is there a better place for me to submit this, or would someone have the > spare time to take a look ? Yes, ports@ would be a better place. :) --+rRWuC8ZLvVekNoN Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQF8BAEBCgBmBQJXPvZHXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQ4RjQwMDE3RTRERjUzMTI1N0FGRTUxNDlF NTRDQjM3RDNBMDg5RDZEAAoJEOVMs306CJ1tiBQH/2gQrImjZP39CkeUYs3K4WwH 7QAIsfcqySikhKLl31uaYYE93SEPNSEXdL+YztUaAHvOSbKJCfZSPes5+4V5ROD1 ti8MkWhgxi8DdjeIW/ilkyZyn/t+OsRGFg6libdxxhQLni3ICDvK/YKelbV2gvHf Rl5CXLb0zWk9AWuxTCr1ri5J2QBBvOAH97qx9zJJFVRyV83SEtMOTngRTzbEyzvB mYuyrzMALtkrOgXVYsja++BDlVR0GETkSRyjtrIFBGMilR6z5MYvMSxI4YIj1Vhh /Stm1qen7UcOVg2hC5/+fV6Grw3VhMAwqk4ea+V6PYYUphFo6kuGBnVKZVxWPDY= =Dsme -----END PGP SIGNATURE----- --+rRWuC8ZLvVekNoN--