From nobody Wed Aug 10 20:07:33 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M31FK4ZFbz4Y68k; Wed, 10 Aug 2022 20:07:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M31FK3h32z3qFf; Wed, 10 Aug 2022 20:07:33 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660162053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TmqIB9hk4OtJ1JtYfe01F1KI7o3EUtCDm/bJHrMV7DY=; b=UKZ5MGqKIsET/oSILcDrLwRTGDF+nN/EDukP9EWEiyr2MQkoKb7/McKI26oHizk/PN1yjv qai9LQY0ET9RGZo3MNO3tCyic4eVfaasibzJh01gbccBQBjA/z1JCBIVvOYNQia6rEFw2a PJZYdH0B/h7PYSevaw5QYzMyodVxKqylOh0V3Dz6IlTGs/LNqwYCDhDSC8cqqWTUydCC57 q8akNe1JVeLPu9R6XX3lW0dHHEomAhO3P1F1jX1yx+6EBx+6Uep1uCphzLxLIn8UuWTEHf BmQG47ZJx2Zdo5lVOqECasTE9L//0K9CUMoO63WupiH/CgA9j67gLBdFRFQi8A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4M31FK2ZJ5zPbD; Wed, 10 Aug 2022 20:07:33 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 27AK7XU9001056; Wed, 10 Aug 2022 20:07:33 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 27AK7X2s001055; Wed, 10 Aug 2022 20:07:33 GMT (envelope-from git) Date: Wed, 10 Aug 2022 20:07:33 GMT Message-Id: <202208102007.27AK7X2s001055@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Emmanuel Vadot Subject: git: 1ee7a8049218 - main - sdio: Always use increment address for read/write_4 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: manu X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1ee7a8049218e6dc0a520e6e298626d11d254a2b Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1660162053; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=TmqIB9hk4OtJ1JtYfe01F1KI7o3EUtCDm/bJHrMV7DY=; b=DBMqadaqCwNYlqPlLx4ZWkENKUfqsuqMY32X3jgVoRb7TZmPMJxwBZP1YdqpPxLHbIa/q9 gNPussVkaS0aztVr+NC7LVcyE8k0O5kMLXgFXPTPRxW7tiVFlZ249R1fXsLGL9Bz1qsLJy RcdGoXHwoAdj9UOz/IQy2CN4/5RsTmb0DKOfKlqGf3oGU1ZQ5jTwV1GUJeudk17D7cOaXp N26t9XTJ1kcJWRZVBDrYwGH6LvgrYg6LhEz9AcMkbEtleqU1QFpzChpnul/ORFu9a3j15h /kUyL2EjINWhiwCvAcDV+JjMcdUbmjeWZWXNvFhkfuE61CkQUyZ6MY94JUvjgg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1660162053; a=rsa-sha256; cv=none; b=yDitpyIoduYwXwqb5HyJMezetpzTh/Ob8K4XdIdKDO2WjVlujX3SW9gCAoEN1NlbDsH20X Rwj+h4kEoEL2muuZgCvnVHO5Jk9Fyyk+2sT8/JfKkCAbIEeNgblfd4YIjwzI0enxB/AYlO 51+AA7SOadd9ds1Zg9j4i3WSBosE23d2EbCJmaSOKIPN/O910vLo89Zv7VboYv29JniOvK Ycwb7vHQObPANXo75vdPR8h3iZdx51QG9KWw/x5rasZW52k6cproIOqkQDRAkkAspNfb4f MgjDE2Slqbi2MxzsS/3w/itl5xHXYWlk0R9tFCtXdKGVYUasWa0lfpylpEavHw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by manu: URL: https://cgit.FreeBSD.org/src/commit/?id=1ee7a8049218e6dc0a520e6e298626d11d254a2b commit 1ee7a8049218e6dc0a520e6e298626d11d254a2b Author: Emmanuel Vadot AuthorDate: 2021-05-21 11:33:34 +0000 Commit: Emmanuel Vadot CommitDate: 2022-08-10 20:07:23 +0000 sdio: Always use increment address for read/write_4 SDIO CMD53 (RW Extented) can either write to the same address (useful for FIFO) or auto increment the destination address (to write to multiple registers). It is more logical to have read/write_4 to use incremental mode and make other helper function for writing to a FIFO destination especially since most FIFO write/read will be 8bits based and not 32bits based. --- sys/dev/sdio/sdio_subr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/dev/sdio/sdio_subr.c b/sys/dev/sdio/sdio_subr.c index 55f09a55a02b..0885b16550a6 100644 --- a/sys/dev/sdio/sdio_subr.c +++ b/sys/dev/sdio/sdio_subr.c @@ -173,7 +173,7 @@ sdio_read_4(struct sdio_func *f, uint32_t addr, int *err) uint32_t v; error = SDIO_READ_EXTENDED(device_get_parent(f->dev), f->fn, addr, - sizeof(v), (uint8_t *)&v, false); + sizeof(v), (uint8_t *)&v, true); if (error) { if (err != NULL) *err = error; @@ -191,7 +191,7 @@ sdio_write_4(struct sdio_func *f, uint32_t addr, uint32_t val, int *err) int error; error = SDIO_WRITE_EXTENDED(device_get_parent(f->dev), f->fn, addr, - sizeof(val), (uint8_t *)&val, false); + sizeof(val), (uint8_t *)&val, true); if (err != NULL) *err = error; }