From owner-freebsd-bugs@FreeBSD.ORG Wed Jul 21 14:20:02 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 449BF106567B for ; Wed, 21 Jul 2010 14:20:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 094368FC0C for ; Wed, 21 Jul 2010 14:20:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o6LEK1LK083345 for ; Wed, 21 Jul 2010 14:20:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o6LEK1o4083344; Wed, 21 Jul 2010 14:20:01 GMT (envelope-from gnats) Resent-Date: Wed, 21 Jul 2010 14:20:01 GMT Resent-Message-Id: <201007211420.o6LEK1o4083344@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, pluknet Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 89436106564A for ; Wed, 21 Jul 2010 14:16:33 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 785B58FC14 for ; Wed, 21 Jul 2010 14:16:33 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o6LEGXcV090062 for ; Wed, 21 Jul 2010 14:16:33 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o6LEGXDW090061; Wed, 21 Jul 2010 14:16:33 GMT (envelope-from nobody) Message-Id: <201007211416.o6LEGXDW090061@www.freebsd.org> Date: Wed, 21 Jul 2010 14:16:33 GMT From: pluknet To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/148820: [patch] [ext2fs] duplicated comment block cleanup X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jul 2010 14:20:02 -0000 >Number: 148820 >Category: kern >Synopsis: [patch] [ext2fs] duplicated comment block cleanup >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Jul 21 14:20:01 UTC 2010 >Closed-Date: >Last-Modified: >Originator: pluknet >Release: HEAD r209037 >Organization: >Environment: >Description: ext2_alloc() has a leading duplicated comment. This patch removes the second copy. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: sys/fs/ext2fs/ext2_alloc.c =================================================================== --- sys/fs/ext2fs/ext2_alloc.c (revision 209037) +++ sys/fs/ext2fs/ext2_alloc.c (working copy) @@ -75,20 +75,6 @@ * inode for the file. * 2) quadradically rehash into other cylinder groups, until an * available block is located. - * - * A preference may be optionally specified. If a preference is given - * the following hierarchy is used to allocate a block: - * 1) allocate the requested block. - * 2) allocate a rotationally optimal block in the same cylinder. - * 3) allocate a block in the same cylinder group. - * 4) quadradically rehash into other cylinder groups, until an - * available block is located. - * If no block preference is given the following hierarchy is used - * to allocate a block: - * 1) allocate a block in the cylinder group that contains the - * inode for the file. - * 2) quadradically rehash into other cylinder groups, until an - * available block is located. */ int >Release-Note: >Audit-Trail: >Unformatted: