From owner-cvs-all Sat Jan 8 5:38: 8 2000 Delivered-To: cvs-all@freebsd.org Received: from info.iet.unipi.it (info.iet.unipi.it [131.114.9.184]) by hub.freebsd.org (Postfix) with ESMTP id 927E3158DB; Sat, 8 Jan 2000 05:38:02 -0800 (PST) (envelope-from luigi@info.iet.unipi.it) Received: (from luigi@localhost) by info.iet.unipi.it (8.9.3/8.9.3) id OAA10400; Sat, 8 Jan 2000 14:38:24 +0100 (CET) (envelope-from luigi) From: Luigi Rizzo Message-Id: <200001081338.OAA10400@info.iet.unipi.it> Subject: Re: cvs commit: src/sys/netinet ip_dummynet.c ip_dummynet.h In-Reply-To: <20000108214808C.shin@nd.net.fujitsu.co.jp> from Yoshinobu Inoue at "Jan 8, 2000 09:48:08 pm" To: Yoshinobu Inoue Date: Sat, 8 Jan 2000 14:38:23 +0100 (CET) Cc: luigi@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG X-Mailer: ELM [version 2.4ME+ PL61 (25)] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > Please pass pkt->flags value as ip_output() flags argument, > if it is not problem. it _is_ passed, just not in the ip_output() argument but through the pkt structure --look at the changes in ip_output.c > By the way, > > > as well. Also (probably) fix a bug introduced during the IPv6 import. > > did I break anything related to dummynet? > I thought I only changed ip_output() arguments related part, > and also confirmed it to work, but if there was any problem, > I'm much sorry for it. no reason to apologise :) Thanks for your work, indeed! I am not 100% sure but I think the flag argument was already used for some other purpose to pass parameters to ip_output() (probably the destination interface or something like that). So your change might have rendered that parameter invalid, but if memory serves, the bug would be only evidenced with multihomed systems and/or acting as gateways. cheers luigi -----------------------------------+------------------------------------- Luigi RIZZO, luigi@iet.unipi.it . Dip. di Ing. dell'Informazione http://www.iet.unipi.it/~luigi/ . Universita` di Pisa TEL/FAX: +39-050-568.533/522 . via Diotisalvi 2, 56126 PISA (Italy) Mobile +39-347-0373137 -----------------------------------+------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message