From owner-freebsd-current Sun Jan 5 10:52: 5 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 67E6637B401 for ; Sun, 5 Jan 2003 10:52:04 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8977443EB2 for ; Sun, 5 Jan 2003 10:52:03 -0800 (PST) (envelope-from phk@freebsd.org) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h05IptAS009631; Sun, 5 Jan 2003 19:51:56 +0100 (CET) (envelope-from phk@freebsd.org) To: Bruce Evans Cc: current@freebsd.org Subject: Re: specfs lock plumbing broken From: phk@freebsd.org In-Reply-To: Your message of "Mon, 06 Jan 2003 05:47:21 +1100." <20030106050703.N401-100000@gamplex.bde.org> Date: Sun, 05 Jan 2003 19:51:55 +0100 Message-ID: <9630.1041792715@critter.freebsd.dk> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20030106050703.N401-100000@gamplex.bde.org>, Bruce Evans writes: >On Sun, 5 Jan 2003 phk@freebsd.org wrote: > >> I always wondered why specfs would insist on no locking, but I never >> had much ambition for finding out. > >Me too. It seems to be mostly a mistake. > >> >Fixing specfs is simple: >> >> This is not tested with DEVFS I take it ? > >It doesn't affect devfs because devfs doesn't go through ufs. It goes >straight to the default vnodeop table so it gets std* since it doesn't >override them. Uhm, no. DEVFS only goes to the default vector for directories, for devices it goes to spec_vnoperate. >I'm getting some other panics. One while writing this was >"bwrite: buffer is not busy???". Yes, I'm hunting that one atm, but havn't found a way to reproduce. Did you get any complaints about the wrong strategy for the wrong type of node before this panic ? Do you have DEBUG_VFS_LOCKS in your kernel ? -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message