From owner-freebsd-current  Sun Aug 25 18:11:58 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8117737B400; Sun, 25 Aug 2002 18:11:56 -0700 (PDT)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 112E043E65; Sun, 25 Aug 2002 18:11:55 -0700 (PDT)
	(envelope-from bde@zeta.org.au)
Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id BAA15916;
	Mon, 26 Aug 2002 01:11:52 GMT
Date: Mon, 26 Aug 2002 11:18:36 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: "David O'Brien" <obrien@FreeBSD.ORG>
Cc: Mike Barcroft <mike@FreeBSD.ORG>,
	Craig Rodrigues <rodrigc@attbi.com>, <freebsd-current@FreeBSD.ORG>
Subject: Re: Question about device.hints man page
In-Reply-To: <20020825200236.GB82354@dragon.nuxi.com>
Message-ID: <20020826110535.K705-100000@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Sun, 25 Aug 2002, David O'Brien wrote:

> On Sun, Aug 25, 2002 at 12:43:44PM -0400, Mike Barcroft wrote:
> > Craig Rodrigues <rodrigc@attbi.com> writes:
> > > device.hints.5:
> > >      $FreeBSD: src/share/man/man5/device.hints.5,v 1.3 2002/08/09 06:07:33 obrien Exp $
> > > I would like to submit the following trivial patch:
> > >
> > >
> > > --- device.hints.5.orig	Sun Aug 25 12:52:02 2002
> > > +++ device.hints.5	Sun Aug 25 12:52:26 2002
> > > @@ -145,7 +145,7 @@
> > >
> > >  The following example disables the ACPI driver
> > >  .Bd -literal -offset indent
> > > -hint.acpi.0.disable="1"
> > > +hint.acpi.0.disabled="1"
> > >  .Ed
> > >  .\" .Pp
> > >  .\" A control variable may look like:
> >
> >
> > Committed, thanks.
>
> Uh WAIT!  Was this tested?!?
> $ grep disable /sys/boot/i386/libi386/i386_module.c
>     if ((getenv("acpi_load") && !getenv("hint.acpi.0.disable"))) {
>
> "hint.acpi.0.disable=1" certainly did not load the acpi.ko module for me
> (as expected by inspecting the code).  I'm backing this commit out
> someone can prove it is proper.

It seems to be proper for disabling acpi itself (see dev/acpica/acpi.c)
but not its loading.  So to fully disable acpica, you have to do something
like:

    hint.acpi.0.disable="I prefer not to use code that (mis)uses !getenv()"
    hint.acpi.0.disabled="1"

Bruce


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message