From owner-svn-src-head@freebsd.org Wed Jul 20 16:37:01 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F04D1B9F770 for ; Wed, 20 Jul 2016 16:37:01 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-pf0-x234.google.com (mail-pf0-x234.google.com [IPv6:2607:f8b0:400e:c00::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C134A1348 for ; Wed, 20 Jul 2016 16:37:01 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-pf0-x234.google.com with SMTP id h186so20705026pfg.3 for ; Wed, 20 Jul 2016 09:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=q5XRxHZpy2RFa0Rbfu+aNlEGQEzcjwb2VL/U05U4DuA=; b=EBuhp8k5EUwj4I60OR5gA41emdOLMCG9Wh/45RgwrZFfytxXlskRB25IuFX7M4/6CK 8VZckhuFzFY37lfXbEWFRSZ5S3rzcmZzS/4MfZB4gIaM3SX2O3KPlXxLFBr4pNdlcB8C nddbEhb0dmbr+UclufQHkqnwxO+t7kEikFqDk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=q5XRxHZpy2RFa0Rbfu+aNlEGQEzcjwb2VL/U05U4DuA=; b=SV4G4JrjFc/h4lv4kgjIK2APcMItVX+XcPSZBwMeCn036tUpBt/NQJfvskezkuVPKD /250bo3idEg+zKClVXF/+saX34RwxnlKUJE659ktrAMp9iqeSne/oHj1cgzdEaSp4mlm //T/S8GqF2SdoeM4e8rGn/dAL08sQEfWD+DE5I45QR2bqv72bv1EcjxLdVhT7Z4bdJb7 I0vkio3UD6w1KcAs21NyYFvr93qVPuobpCifqrK9eqjPAyIOh2cNK1yKe1z8DGhmvNzf OOM93+S5MC/puUyIYhEbTwZFZTwrHCewcZclBmnh/pl7iqv9jJMx2lZnxXtt7fE2MmlP wvFg== X-Gm-Message-State: ALyK8tIxQi8HppXsQP2MD7Iyw/gDr6fT+EseBS6A/h+8WjyK2MXITO9Bgce78AiYRnnsnq+z X-Received: by 10.98.77.65 with SMTP id a62mr66104464pfb.128.1469032620968; Wed, 20 Jul 2016 09:37:00 -0700 (PDT) Received: from [100.127.67.9] ([69.53.245.200]) by smtp.gmail.com with ESMTPSA id n5sm5867740pai.11.2016.07.20.09.36.58 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Jul 2016 09:37:00 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r303037 - head/sys/kern From: Randall Stewart In-Reply-To: <20160720163501.GY1076@FreeBSD.org> Date: Wed, 20 Jul 2016 18:36:55 +0200 Cc: Randall Ray Stewart , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <6135F2B2-6543-4A06-92D3-5BC7F75ED320@netflix.com> References: <201607191831.u6JIVJWq007542@repo.freebsd.org> <20160720065335.GU1076@FreeBSD.org> <1CA02E0F-6871-4291-9F5A-20EFF5F6315D@netflix.com> <20160720163501.GY1076@FreeBSD.org> To: Gleb Smirnoff X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jul 2016 16:37:02 -0000 You are most welcome to backout anything you like.. as far as I am concerned you own the code.. R > On Jul 20, 2016, at 6:35 PM, Gleb Smirnoff = wrote: >=20 > Randall, >=20 > I have just tested and r303037 brings the TCP panic back. I > got two crashes during 2.5 hours. >=20 > In your email [1] you are right, there is regression that (-1) > return value is lost. This problem was worked on in the PR 210884, > and we were very close to commiting the fix. >=20 > The whole 11.0-RELEASE cycle strongly depends on this change. We > don't want to release with TCP panic, and of course we want the > regression described in 210884 to be fixed. >=20 > Your backout mixed with extra code really made things messy. Since > I don't want to go with commit war, on behalf of RE we are asking > for explicit agreement to back out r303037. Then we will proceed with > latest patch from 210884. Is that okay? >=20 > [1] = https://lists.freebsd.org/pipermail/svn-src-head/2016-July/089313.html >=20 > On Wed, Jul 20, 2016 at 03:33:37PM +0200, Randall Stewart wrote: > R> Gleb > R>=20 > R> I wish you would have responded earlier.. I am more than glad to = hand > R> off all kern_timeout.c to you=E2=80=A6 please take it commit what = you want to > R> it and have it. I hate the code and I dislike having to touch it. > R>=20 > R> Its yours.. I can assure you I will not touch it again. > R>=20 > R> R > R> > On Jul 20, 2016, at 8:53 AM, Gleb Smirnoff = wrote: > R> >=20 > R> > On Tue, Jul 19, 2016 at 06:31:19PM +0000, Randall Stewart wrote: > R> > R> Author: rrs > R> > R> Date: Tue Jul 19 18:31:19 2016 > R> > R> New Revision: 303037 > R> > R> URL: https://svnweb.freebsd.org/changeset/base/303037 > R> > R>=20 > R> > R> Log: > R> > R> This reverts out Gleb's changes and adds three small > R> > R> fixes that I think closes up the races Gleb was > R> > R> looking for. This is running quite nicely in Netflix and > R> > R> now no longer causes TCP-tcb leaks. > R> > R> =20 > R> > R> Differential Revision: 7135 > R> >=20 > R> > Just to notice that I am completely pissed of by this commit > R> > war, that you started. > R> >=20 > R> > I've been testing my changes properly, I gave people time to > R> > review my changes. You didn't. > R> >=20 > R> > =46rom your explanation in other emails I see that you've been > R> > testing your changes with a version of FreeBSD that is a heavily > R> > modified FreeBSD 10, not 11. > R> >=20 > R> > The new code you mixed with revert of mine, doesn't fix the > R> > problem observed. It fixes another problem that you imagined, > R> > which might exist, but isn't observed. We already discussed that > R> > and you didn't prove it wrong. > R> >=20 > R> > Your change doesn't even revert my change completely. > R> >=20 > R> > --=20 > R> > Totus tuus, Glebius. > R>=20 > R> -------- > R> Randall Stewart > R> rrs@netflix.com > R> 803-317-4952 > R>=20 > R>=20 > R>=20 > R>=20 > R>=20 > R>=20 >=20 > --=20 > Totus tuus, Glebius. -------- Randall Stewart rrs@netflix.com 803-317-4952