From owner-cvs-all@FreeBSD.ORG Thu Jun 16 16:47:33 2011 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 471ED106567E; Thu, 16 Jun 2011 16:47:33 +0000 (UTC) Date: Thu, 16 Jun 2011 16:47:33 +0000 From: Alexey Dokuchaev To: Wen Heping Message-ID: <20110616164733.GA40181@FreeBSD.org> References: <201106160842.p5G8gS6T054738@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <201106160842.p5G8gS6T054738@repoman.freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/sysutils/tmux Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2011 16:47:33 -0000 On Thu, Jun 16, 2011 at 08:42:28AM +0000, Wen Heping wrote: > wen 2011-06-16 08:42:28 UTC > > Modified files: > sysutils/tmux Makefile > Log: > - Fix build when CFLAGS is set in /etc/make.conf Hmm, default CPPFLAGS is empty. Judging just from the diff, instead of introducing EXTRA_CPPFLAGS, setting CPPFLAGS instead of CFLAGS (which is bogus in the first place: -I is preprocessor flag) should be enough (no MAKE_ENV adjustment and extra REINPLACE_CMD hack would be required in this case as well). I am missing something obvious here? ./danfe