From owner-svn-src-head@FreeBSD.ORG Fri Jun 28 08:10:06 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 796C3191; Fri, 28 Jun 2013 08:10:06 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-wi0-x236.google.com (mail-wi0-x236.google.com [IPv6:2a00:1450:400c:c05::236]) by mx1.freebsd.org (Postfix) with ESMTP id 6C7CB1AC8; Fri, 28 Jun 2013 08:10:05 +0000 (UTC) Received: by mail-wi0-f182.google.com with SMTP id m6so452834wiv.9 for ; Fri, 28 Jun 2013 01:10:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:reply-to:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=YUwaQN2EyCEwFOrZGHyWSiCuhqxfKeQI9WycdwK1ja8=; b=i3j7i+256ycXkcLiwHnWR5sL8EjwP4bgSq9lW9ZhJFa7xLmBf/Hp+2ukBlieHlQgPY AQlYpv3kcecVikXoBnREXexCsBrumSLpR6Fcz0q30R8N6DYbwn/VlPpV3y+O4pIS1h78 S0s5vhH3QJMPElO8B6kdU7rTa0wsFZ62wMl45PYM3Ybzd6AspIQyauMSJhIOWjMLhSA3 04uYgpGtfmaMABkOxPt0kHe4diIfUDGMpn+otz5pRFb3TbDrq/+qoG0bZrKzqmEHn2wP 0IGfkTLq5h8cFFQqAsrbJW0OTcjCTOy1xx4wf5wJaI/XArl/M9/7zh7KDscusQ6VJp6X /PEg== MIME-Version: 1.0 X-Received: by 10.180.183.40 with SMTP id ej8mr1555441wic.37.1372407004532; Fri, 28 Jun 2013 01:10:04 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.194.154.135 with HTTP; Fri, 28 Jun 2013 01:10:04 -0700 (PDT) In-Reply-To: <201306271034.11852.jhb@freebsd.org> References: <201306251844.r5PIiFDZ009708@svn.freebsd.org> <51CA97AE.4090306@freebsd.org> <201306271034.11852.jhb@freebsd.org> Date: Fri, 28 Jun 2013 10:10:04 +0200 X-Google-Sender-Auth: ty3p7MMDRRXa4qPNO0Fu1CM-VWI Message-ID: Subject: Re: svn commit: r252209 - in head: share/man/man9 sys/kern sys/sys From: Attilio Rao To: John Baldwin Content-Type: text/plain; charset=UTF-8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Andre Oppermann X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: attilio@FreeBSD.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jun 2013 08:10:06 -0000 On Thu, Jun 27, 2013 at 4:34 PM, John Baldwin wrote: > On Wednesday, June 26, 2013 3:26:38 am Andre Oppermann wrote: >> On 25.06.2013 20:44, John Baldwin wrote: >> > Author: jhb >> > Date: Tue Jun 25 18:44:15 2013 >> > New Revision: 252209 >> > URL: http://svnweb.freebsd.org/changeset/base/252209 >> > >> > Log: >> > Several improvements to rmlock(9). Many of these are based on patches >> > provided by Isilon. >> > - Add an rm_assert() supporting various lock assertions similar to other >> > locking primitives. Because rmlocks track readers the assertions are >> > always fully accurate unlike rw_assert() and sx_assert(). >> > - Flesh out the lock class methods for rmlocks to support sleeping via >> > condvars and rm_sleep() (but only while holding write locks), rmlock >> > details in 'show lock' in DDB, and the lc_owner method used by >> > dtrace. >> > - Add an internal destroyed cookie so that API functions can assert >> > that an rmlock is not destroyed. >> > - Make use of rm_assert() to add various assertions to the API (e.g. >> > to assert locks are held when an unlock routine is called). >> > - Give RM_SLEEPABLE locks their own lock class and always use the >> > rmlock's own lock_object with WITNESS. >> > - Use THREAD_NO_SLEEPING() / THREAD_SLEEPING_OK() to disallow sleeping >> > while holding a read lock on an rmlock. >> >> Thanks! >> >> Would it make sense to move struct rm_queue from struct pcpu itself to >> using DPCPU as a next step? > > Perhaps. It might make pcpu.h cleaner, aside from that concern I don't think > it really matters much. It cannot for performance reasons. I had a comment ready for this but I'm not sure if it was ever committed. Attilio -- Peace can only be achieved by understanding - A. Einstein