Date: Wed, 15 Sep 2021 10:33:04 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Emmanuel Vadot <manu@FreeBSD.org>, ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: Re: git: 4f3befc2a362 - main - ports-mgmt/pkg-devel: Add an option for building with sanitizer Message-ID: <a045eb42-d730-ee5a-baf9-cdb16bd2ca9d@FreeBSD.org> In-Reply-To: <202109141010.18EAA5Yb091282@gitrepo.freebsd.org> References: <202109141010.18EAA5Yb091282@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14/09/2021 8:10 pm, Emmanuel Vadot wrote:
> +.if ${PORT_OPTIONS:MSAN}
> +CONFIGURE_ARGS+= --with-asan --with-ubsan
> +.endif
> +
Might be worth providing two options for these, as we seek to enable
them in more ports across the board as a longer term target.
That way the options and options descriptions can be shared, and used
individually, as I imagine there are going to be plenty of cases where
one can be used but not the other, at various times, or for various
reasons.
Also, should use CONFIGURE_WITH unless the softwares autoconf
(configure.ac) doesn't support it (it should).
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a045eb42-d730-ee5a-baf9-cdb16bd2ca9d>