From owner-svn-src-head@freebsd.org Wed Mar 6 15:00:33 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id DA98F151A075; Wed, 6 Mar 2019 15:00:32 +0000 (UTC) (envelope-from pho@holm.cc) Received: from relay01.pair.com (relay01.pair.com [209.68.5.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id B4DC9904D6; Wed, 6 Mar 2019 15:00:31 +0000 (UTC) (envelope-from pho@holm.cc) Received: from x2.osted.lan (87-58-223-204-dynamic.dk.customer.tdc.net [87.58.223.204]) by relay01.pair.com (Postfix) with ESMTP id 06B9DD02539; Wed, 6 Mar 2019 10:00:24 -0500 (EST) Received: from x2.osted.lan (localhost [127.0.0.1]) by x2.osted.lan (8.15.2/8.15.2) with ESMTPS id x26F0KQn072323 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 6 Mar 2019 16:00:20 +0100 (CET) (envelope-from pho@x2.osted.lan) Received: (from pho@localhost) by x2.osted.lan (8.15.2/8.15.2/Submit) id x26F0KTl072322; Wed, 6 Mar 2019 16:00:20 +0100 (CET) (envelope-from pho) Date: Wed, 6 Mar 2019 16:00:20 +0100 From: Peter Holm To: Fedor Uporov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344757 - head/sys/fs/ext2fs Message-ID: <20190306150020.GA72148@x2.osted.lan> References: <201903041133.x24BXnuY035956@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201903041133.x24BXnuY035956@repo.freebsd.org> User-Agent: Mutt/1.11.1 (2018-12-01) X-Rspamd-Queue-Id: B4DC9904D6 X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [0.12 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.56)[-0.557,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; NEURAL_SPAM_SHORT(0.35)[0.346,0]; NEURAL_HAM_LONG(-0.59)[-0.592,0]; RCVD_COUNT_THREE(0.00)[4]; IP_SCORE(-0.17)[ip: (0.28), ipnet: 209.68.0.0/18(-0.53), asn: 7859(-0.54), country: US(-0.07)]; MX_GOOD(-0.01)[mailwash28.pair.com]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[pho@freebsd.org,pho@holm.cc]; RCVD_IN_DNSWL_LOW(-0.10)[15.5.68.209.list.dnswl.org : 127.0.5.1]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:7859, ipnet:209.68.0.0/18, country:US]; FROM_NEQ_ENVFROM(0.00)[pho@freebsd.org,pho@holm.cc]; RECEIVED_SPAMHAUS_PBL(0.00)[204.223.58.87.zen.spamhaus.org : 127.0.0.11] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2019 15:00:33 -0000 On Mon, Mar 04, 2019 at 11:33:49AM +0000, Fedor Uporov wrote: > Author: fsu > Date: Mon Mar 4 11:33:49 2019 > New Revision: 344757 > URL: https://svnweb.freebsd.org/changeset/base/344757 > > Log: > Fix double free in case of mount error. > > Reported by: Christopher Krah > Reported as: FS-9-EXT3-2: Denial Of Service in nmount-5 (vm_fault_hold) > Reviewed by: pfg > MFC after: 1 week > > Differential Revision: https://reviews.freebsd.org/D19385 > > Modified: > head/sys/fs/ext2fs/ext2_vfsops.c > > Modified: head/sys/fs/ext2fs/ext2_vfsops.c > ============================================================================== > --- head/sys/fs/ext2fs/ext2_vfsops.c Mon Mar 4 11:27:47 2019 (r344756) Could this panic be related to your latest ext2fs changes? 20190306 15:27:47 all (309/617): crossmp10.sh panic: mutex EXT2FS not owned at ../../../kern/kern_mutex.c:281 cpuid = 9 time = 1551882471 KDB: stack backtrace: db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00bfb3f480 vpanic() at vpanic+0x1b4/frame 0xfffffe00bfb3f4e0 panic() at panic+0x43/frame 0xfffffe00bfb3f540 __mtx_unlock_flags() at __mtx_unlock_flags+0x13a/frame 0xfffffe00bfb3f570 ext2_valloc() at ext2_valloc+0x530/frame 0xfffffe00bfb3f620 ext2_makeinode() at ext2_makeinode+0x56/frame 0xfffffe00bfb3f680 ext2_create() at ext2_create+0x2d/frame 0xfffffe00bfb3f6a0 VOP_CREATE_APV() at VOP_CREATE_APV+0x86/frame 0xfffffe00bfb3f6d0 vn_open_cred() at vn_open_cred+0x2c3/frame 0xfffffe00bfb3f820 kern_openat() at kern_openat+0x1fd/frame 0xfffffe00bfb3f990 amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00bfb3fab0 fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00bfb3fab0 https://people.freebsd.org/~pho/stress/log/crossmp10-2.txt - Peter