Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Mar 2019 16:00:20 +0100
From:      Peter Holm <pho@freebsd.org>
To:        Fedor Uporov <fsu@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r344757 - head/sys/fs/ext2fs
Message-ID:  <20190306150020.GA72148@x2.osted.lan>
In-Reply-To: <201903041133.x24BXnuY035956@repo.freebsd.org>
References:  <201903041133.x24BXnuY035956@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Mar 04, 2019 at 11:33:49AM +0000, Fedor Uporov wrote:
> Author: fsu
> Date: Mon Mar  4 11:33:49 2019
> New Revision: 344757
> URL: https://svnweb.freebsd.org/changeset/base/344757
> 
> Log:
>   Fix double free in case of mount error.
>   
>   Reported by:    Christopher Krah <krah@protonmail.com>
>   Reported as:    FS-9-EXT3-2: Denial Of Service in nmount-5 (vm_fault_hold)
>   Reviewed by:    pfg
>   MFC after:      1 week
>   
>   Differential Revision:    https://reviews.freebsd.org/D19385
> 
> Modified:
>   head/sys/fs/ext2fs/ext2_vfsops.c
> 
> Modified: head/sys/fs/ext2fs/ext2_vfsops.c
> ==============================================================================
> --- head/sys/fs/ext2fs/ext2_vfsops.c	Mon Mar  4 11:27:47 2019	(r344756)

Could this panic be related to your latest ext2fs changes?

20190306 15:27:47 all (309/617): crossmp10.sh
panic: mutex EXT2FS not owned at ../../../kern/kern_mutex.c:281
cpuid = 9
time = 1551882471
KDB: stack backtrace:
db_trace_self_wrapper() at db_trace_self_wrapper+0x2b/frame 0xfffffe00bfb3f480
vpanic() at vpanic+0x1b4/frame 0xfffffe00bfb3f4e0
panic() at panic+0x43/frame 0xfffffe00bfb3f540
__mtx_unlock_flags() at __mtx_unlock_flags+0x13a/frame 0xfffffe00bfb3f570
ext2_valloc() at ext2_valloc+0x530/frame 0xfffffe00bfb3f620
ext2_makeinode() at ext2_makeinode+0x56/frame 0xfffffe00bfb3f680
ext2_create() at ext2_create+0x2d/frame 0xfffffe00bfb3f6a0
VOP_CREATE_APV() at VOP_CREATE_APV+0x86/frame 0xfffffe00bfb3f6d0
vn_open_cred() at vn_open_cred+0x2c3/frame 0xfffffe00bfb3f820
kern_openat() at kern_openat+0x1fd/frame 0xfffffe00bfb3f990
amd64_syscall() at amd64_syscall+0x291/frame 0xfffffe00bfb3fab0
fast_syscall_common() at fast_syscall_common+0x101/frame 0xfffffe00bfb3fab0

https://people.freebsd.org/~pho/stress/log/crossmp10-2.txt

- Peter



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190306150020.GA72148>