From owner-freebsd-current Thu Dec 5 8: 2:53 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49A0A37B407 for ; Thu, 5 Dec 2002 08:02:44 -0800 (PST) Received: from mail.speakeasy.net (mail16.speakeasy.net [216.254.0.216]) by mx1.FreeBSD.org (Postfix) with ESMTP id 93C7643EC5 for ; Thu, 5 Dec 2002 08:02:43 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: (qmail 798 invoked from network); 5 Dec 2002 16:02:45 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail16.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 5 Dec 2002 16:02:45 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.6/8.12.6) with ESMTP id gB5G2euH044989; Thu, 5 Dec 2002 11:02:40 -0500 (EST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20021204231245.GH58155@elvis.mu.org> Date: Thu, 05 Dec 2002 11:02:47 -0500 (EST) From: John Baldwin To: Alfred Perlstein Subject: Re: Lock order reversals in sys_pipe.c and kern_sig.c Cc: tanimura@FreeBSD.org, current@FreeBSD.org, Kris Kennaway , Lars Eggert Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 04-Dec-2002 Alfred Perlstein wrote: > * Lars Eggert [021204 15:04] wrote: >> >> FYI, just got a similar one yesterday on an up-to-date -current: >> >> lock order reversal >> 1st 0xc784d700 pipe mutex (pipe mutex) @ /usr/src/sys/kern/sys_pipe.c:465 >> 2nd 0xc0513840 sigio lock (sigio lock) @ /usr/src/sys/kern/kern_sig.c:2225 > > Since no one has given me the traceback based on the patch I posted > earlier I have ceased to care about the "problem". If someone > seriously cares they will run with my patch and post a backtrace. Your patch doesn't work because it makes a bogus assumption. A better try would be this: Index: subr_witness.c =================================================================== RCS file: /usr/cvs/src/sys/kern/subr_witness.c,v retrieving revision 1.130 diff -u -r1.130 subr_witness.c --- subr_witness.c 11 Nov 2002 16:36:20 -0000 1.130 +++ subr_witness.c 18 Nov 2002 20:42:35 -0000 @@ -205,6 +205,9 @@ { "uidinfo hash", &lock_class_mtx_sleep }, { "uidinfo struct", &lock_class_mtx_sleep }, { NULL, NULL }, + { "sigio lock", &lock_class_mtx_sleep }, + { "pipe mutex", &lock_class_mtx_sleep }, + { NULL, NULL }, /* * spin locks */ -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message