From owner-freebsd-current@FreeBSD.ORG Fri May 26 20:15:14 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 787AA16A9D2 for ; Fri, 26 May 2006 20:15:14 +0000 (UTC) (envelope-from peterjeremy@optushome.com.au) Received: from mail19.syd.optusnet.com.au (mail19.syd.optusnet.com.au [211.29.132.200]) by mx1.FreeBSD.org (Postfix) with ESMTP id C554743D53 for ; Fri, 26 May 2006 20:15:13 +0000 (GMT) (envelope-from peterjeremy@optushome.com.au) Received: from turion.vk2pj.dyndns.org (c220-239-19-236.belrs4.nsw.optusnet.com.au [220.239.19.236]) by mail19.syd.optusnet.com.au (8.12.11/8.12.11) with ESMTP id k4QKEthS024890 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Sat, 27 May 2006 06:14:56 +1000 Received: from turion.vk2pj.dyndns.org (localhost.vk2pj.dyndns.org [127.0.0.1]) by turion.vk2pj.dyndns.org (8.13.6/8.13.6) with ESMTP id k4QKEtD1003507; Sat, 27 May 2006 06:14:55 +1000 (EST) (envelope-from peter@turion.vk2pj.dyndns.org) Received: (from peter@localhost) by turion.vk2pj.dyndns.org (8.13.6/8.13.6/Submit) id k4QKEqMq003506; Sat, 27 May 2006 06:14:52 +1000 (EST) (envelope-from peter) Date: Sat, 27 May 2006 06:14:52 +1000 From: Peter Jeremy To: Alexander Leidinger Message-ID: <20060526201452.GF744@turion.vk2pj.dyndns.org> References: <20060524180802.GA59176@central.0xfce3.net> <200605250517.12054.max@love2party.net> <20060525104000.GA4962@central.0xfce3.net> <20060525115447.GB724@turion.vk2pj.dyndns.org> <17525.55617.272397.806798@grasshopper.cs.duke.edu> <20060526133017.224cff08@Magellan.Leidinger.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060526133017.224cff08@Magellan.Leidinger.net> X-PGP-Key: http://members.optusnet.com.au/peterjeremy/pubkey.asc User-Agent: Mutt/1.5.11 Cc: Gordon Bergling , freebsd-current@freebsd.org, Andrew Gallatin , Max Laier Subject: Re: Take 2: new IP Checksum Code from DragonFlyBSD X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 May 2006 20:15:19 -0000 On Thu, 2006-May-25 12:40:00 +0200, Gordon Bergling wrote: >patch doesn't touch any arch !i386 and derivates, so I don't see any reason >why it shouldn't be included. On Fri, 2006-May-26 13:30:17 +0200, Alexander Leidinger wrote: >The current code is a maze of assembly and macros, the new one is >straight forward C and a little bit of assembly. And the new one is >also known to work in DragonFlyBSD. Do you expect *this* code to act >differently between FreeBSD and DragonFlyBSD? I don't expect the code itself to act differently. But I don't know if FreeBSD and DragonFlyBSD have different expectations of the code - probably they don't but someone (the proponent of the change) needs to confirm this. >What's the technical backing of your preference to stick with the >current code? How does the technical backing of your preference compare >to the technical arguments I presented in this thread regarding the >priority of the arguments? I was responding to Gordon's comments above. If the code is better and there _are_ technical arguments for FreeBSD to use it, then we should. "I don't see any reason not to use it" is not justification for changing critical code. -- Peter Jeremy