From owner-freebsd-net@FreeBSD.ORG  Wed May 23 18:51:28 2012
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: freebsd-net@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 814FD106566C;
	Wed, 23 May 2012 18:51:28 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-pb0-f54.google.com (mail-pb0-f54.google.com
	[209.85.160.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 4EA508FC12;
	Wed, 23 May 2012 18:51:28 +0000 (UTC)
Received: by pbbro2 with SMTP id ro2so11120729pbb.13
	for <multiple recipients>; Wed, 23 May 2012 11:51:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type
	:content-transfer-encoding;
	bh=pvvFHtO5J5A9qfRdI0o7HulSmD9Rh1Gfao5gM2fZ8EA=;
	b=TU9gZ49dPU50pw+LmNpWcNgNrZBJh1MkPzftXr1IhOcshTCOAN/lW7Vq3N/5TZjNQe
	tQWdKuczduoRp+QBaVFAZaz9QuuKhpyeCqARntu3DzTa6ep5tjLnojZDOUagTrfDt9mR
	5S0BirxvKHs43ri5Q4m1vkD2ybCQEDZyEAYt62fydYqHGC6NcLVxFDpl3l9V8IDd+3Zo
	rIRp5galyjgYDPgbPkHVyLmz6TiaCJ7wcPK5YFaPxgMNA98RaAb3mI7cnZqI4UlcG7CL
	txwunRMXnAqBI1iHNM6B3vEOUKXdDes4u0X0GOjs+VJbMWSS5dwWMNPbG56RsHuU3xNu
	zaZQ==
MIME-Version: 1.0
Received: by 10.68.232.129 with SMTP id to1mr3376254pbc.27.1337799087591; Wed,
	23 May 2012 11:51:27 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.142.203.2 with HTTP; Wed, 23 May 2012 11:51:27 -0700 (PDT)
In-Reply-To: <201204201006.q3KA6T6B034501@svn.freebsd.org>
References: <201204201006.q3KA6T6B034501@svn.freebsd.org>
Date: Wed, 23 May 2012 11:51:27 -0700
X-Google-Sender-Auth: UFc263JS4S0xk3A9pp96PgKZwCk
Message-ID: <CAJ-Vmok-JtCSOeh5szcV6oTVFDJYhW6vPdvH5PyLzni1FgQOEg@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Andrew Thompson <thompsa@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-net@freebsd.org
Subject: Re: svn commit: r234488 - head/sys/net
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
	<mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 23 May 2012 18:51:28 -0000

On 20 April 2012 03:06, Andrew Thompson <thompsa@freebsd.org> wrote:
> Author: thompsa
> Date: Fri Apr 20 10:06:28 2012
> New Revision: 234488
> URL: http://svn.freebsd.org/changeset/base/234488
>
> Log:
> =A0Move the interface media check to a taskqueue, some interfaces (usb) s=
leep
> =A0during SIOCGIFMEDIA and we were holding locks.

Hi,

I've noticed this when hacking on switch drivers over i2c/gpio code.
The PHY code can't use sleep or locks because of this.

Do you think it'd maybe be a good idea to simply make the link status
check tick be run through a taskqueue, rather than having it done
direct from the callout swi?


Adrian