From owner-cvs-all Fri Jan 3 3:12:34 2003 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8009A37B401; Fri, 3 Jan 2003 03:12:33 -0800 (PST) Received: from mail.qubesoft.com (gate.qubesoft.com [217.169.36.34]) by mx1.FreeBSD.org (Postfix) with ESMTP id 430C043ED4; Fri, 3 Jan 2003 03:12:32 -0800 (PST) (envelope-from dfr@nlsystems.com) Received: from bluebottle.qubesoft.com (bluebottle.qubesoft.com [192.168.1.2]) by mail.qubesoft.com (8.12.6/8.12.6) with ESMTP id h03BCDoZ005923; Fri, 3 Jan 2003 11:12:13 GMT (envelope-from dfr@nlsystems.com) Received: from builder02.qubesoft.com (builder02.qubesoft.com [192.168.1.8]) by bluebottle.qubesoft.com (8.12.6/8.12.6) with ESMTP id h03BCC7s090742; Fri, 3 Jan 2003 11:12:12 GMT (envelope-from dfr@nlsystems.com) Subject: Re: cvs commit: src/sys/dev/zs zs.c From: Doug Rabson To: Jake Burkholder Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org In-Reply-To: <200301021904.h02J4Z1W084332@repoman.freebsd.org> References: <200301021904.h02J4Z1W084332@repoman.freebsd.org> Content-Type: text/plain Organization: Message-Id: <1041592331.1584.0.camel@builder02.qubesoft.com> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.0 Date: 03 Jan 2003 11:12:12 +0000 Content-Transfer-Encoding: 7bit X-Spam-Status: No, hits=-8.2 required=5.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES,SPAM_PHRASE_00_01 version=2.41 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Thu, 2003-01-02 at 19:04, Jake Burkholder wrote: > jake 2003/01/02 11:04:35 PST > > Modified files: > sys/dev/zs zs.c > Log: > - This damnable chip only has 1 status register for both ports, so the bit > positions for the status bits of port a and port b are different. To > avoid needing to know which channel the interrupt handler is working on, > shift the status bits for port a into the port b bit positions, and always > check the port b status bits. This fixes using port b, which I neglected > to test before. > - Remember to update the channel's tty structure from the passed in termios > in the param routine. > - Minor style. I wonder how much effort it would take to make the alpha zs driver (used for console on some AlphaServers work for both alpha and sparc64. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message