Date: Thu, 22 Oct 2020 21:35:35 +0200 From: Niclas Zeising <zeising@freebsd.org> To: Kyle Evans <kevans@freebsd.org>, Warner Losh <imp@bsdimp.com> Cc: "Alexander V. Chernikov" <melifaro@ipfw.ru>, Hans Petter Selasky <hps@selasky.org>, Emmanuel Vadot <manu@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r366372 - in head/sys: compat/linuxkpi/common/include/linux compat/linuxkpi/common/src conf Message-ID: <d48584a4-50df-70a3-8859-a0fa94f6cc45@freebsd.org> In-Reply-To: <CACNAnaHfeMo6W1ReEq8DGiVy8pURWtvtOCRkr2VW51xiiB7drw@mail.gmail.com> References: <202010021826.092IQfdj023808@repo.freebsd.org> <44421602932538@mail.yandex.ru> <de21fae4-d362-d938-a382-6ab08168e149@selasky.org> <43251602934532@mail.yandex.ru> <f384771b-c68a-ab60-2fe1-e1f2011ea198@selasky.org> <59021602950992@mail.yandex.ru> <CANCZdfoWMxccQBZBry18VDDzyUH2Dr44UasKb4qayxFTiLCGug@mail.gmail.com> <CACNAnaHfeMo6W1ReEq8DGiVy8pURWtvtOCRkr2VW51xiiB7drw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2020-10-22 15:22, Kyle Evans wrote: > On Sat, Oct 17, 2020 at 11:40 AM Warner Losh <imp@bsdimp.com> wrote: >> >> >> >> On Sat, Oct 17, 2020, 10:11 AM Alexander V. Chernikov <melifaro@ipfw.ru> wrote: >>> >>> 17.10.2020, 14:07, "Hans Petter Selasky" <hps@selasky.org>: >>> >>> On 2020-10-17 14:34, Alexander V. Chernikov wrote: >>> >>> 17.10.2020, 12:32, "Hans Petter Selasky" <hps@selasky.org>: >>> >>> On 2020-10-17 13:27, Alexander V. Chernikov wrote: >>> >>> 02.10.2020, 19:26, "Emmanuel Vadot" <manu@freebsd.org >>> <mailto:manu@freebsd.org>>: >>> >>> Author: manu >>> Date: Fri Oct 2 18:26:41 2020 >>> New Revision: 366372 >>> URL: https://svnweb.freebsd.org/changeset/base/366372 >>> >>> Log: >>> linuxkpi: Add backlight support >>> >>> Add backlight function to linuxkpi. >>> Graphics drivers expose the backlight of the panel directly so >>> allow them >>> to use the backlight subsystem so >>> user can use backlight(8) to configure them. >>> >>> Reviewed by: hselasky >>> Relnotes: yes >>> Differential Revision: The FreeBSD Foundation >>> >>> Added: >>> head/sys/compat/linuxkpi/common/include/linux/backlight.h >>> (contents, >>> props changed) >>> Modified: >>> head/sys/compat/linuxkpi/common/include/linux/device.h >>> head/sys/compat/linuxkpi/common/src/linux_kmod.c >>> head/sys/compat/linuxkpi/common/src/linux_pci.c >>> head/sys/conf/kmod.mk >>> >>> It breaks the build for me with >>> /usr/home/melifaro/free/head/sys/compat/linuxkpi/common/src/linux_pci.c:70:10: >>> fatal error: 'backlight_if.h' file not found >>> >>> >>> How do you build? Doesn't break over here. >>> >>> GENERIC + COMPAT_LINUXKPI. >>> >>> >>> >>> Try adding: >>> >>> options backlight >>> >>> To the kernel config. >>> >>> Yep, thank you! >>> Maybe it's worth considering adding static assert with the message describing this dependency? >> >> >> Yes. It likely is worth doing something to highlight this issue. >> >> Warner >> > > I think we just need to slap the two core backlight files with an ` | > compat_linux` so that they simply get pulled in if you specify > COMPAT_LINUX. config(8) handles this terribly, configng must have a > better provides/requires/implies/whatever functionality so we can > specify that compat_linux implies backlight and not do crud like this > where it becomes more complicated to see what any given option really > entails. > > Thanks, COMPAT_LINUX can't be right. Isn't that the linuxolator? Regards -- Niclas Zeising
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d48584a4-50df-70a3-8859-a0fa94f6cc45>