From owner-svn-src-all@FreeBSD.ORG  Tue Aug 19 20:22:26 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 17B3688F;
 Tue, 19 Aug 2014 20:22:26 +0000 (UTC)
Received: from mail-lb0-x236.google.com (mail-lb0-x236.google.com
 [IPv6:2a00:1450:4010:c04::236])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 09B7A3BBB;
 Tue, 19 Aug 2014 20:22:24 +0000 (UTC)
Received: by mail-lb0-f182.google.com with SMTP id z11so5789068lbi.41
 for <multiple recipients>; Tue, 19 Aug 2014 13:22:23 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=sender:date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-disposition:in-reply-to:user-agent;
 bh=0PfSD/rREhj9x+KWEsaJD21oLfcQWqRQLIR/aDPXZ0A=;
 b=R8ZB5iQu5vso3KEHetYODBknrg7rfIGb8U+SW5No6s69OwdSzbTFSmpaWi36DwDRZh
 G60gyiIch5omPQDwlDw/N4TFFPjEzzyaIyyG3zhcbtv+LDyTMRomLcGQPXYxmDFhOLt6
 ymnOzvcB1rvf5fhH/3Mb8rvyhmCPOB37547gWDH4LWxAjzEULX+JNWXiONmKoW93WAU5
 BLpkAWNge9YyHAH6SwAI/a50m0Madq8wzDfppnkWCNK5aE//jNl29WNMY/iZpVcPLks+
 dn/XC1ztF3aD42AsPjuHoYwwJuHIcLraP6N2AUYxgftMAgclLwAWi/V69RYj7zo3yAkx
 H9ww==
X-Received: by 10.152.45.8 with SMTP id i8mr38342673lam.3.1408479742942;
 Tue, 19 Aug 2014 13:22:22 -0700 (PDT)
Received: from localhost ([91.225.202.78])
 by mx.google.com with ESMTPSA id ap2sm8704184lac.22.2014.08.19.13.22.21
 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Tue, 19 Aug 2014 13:22:22 -0700 (PDT)
Sender: Mikolaj Golub <to.my.trociny@gmail.com>
Date: Tue, 19 Aug 2014 23:22:19 +0300
From: Mikolaj Golub <trociny@FreeBSD.org>
To: Garrett Cooper <ngie@FreeBSD.org>
Subject: Re: svn commit: r270117 - head/sbin/hastd
Message-ID: <20140819202218.GA4835@gmail.com>
References: <201408180050.s7I0o9uk035177@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201408180050.s7I0o9uk035177@svn.freebsd.org>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Aug 2014 20:22:26 -0000

On Mon, Aug 18, 2014 at 12:50:09AM +0000, Garrett Cooper wrote:

Hi Garrett,

> Log:
>   Add -ll to LDADD to fix "make checkdpadd"

> Modified: head/sbin/hastd/Makefile
> ==============================================================================
> --- head/sbin/hastd/Makefile	Sun Aug 17 23:30:45 2014	(r270116)
> +++ head/sbin/hastd/Makefile	Mon Aug 18 00:50:09 2014	(r270117)
> @@ -31,7 +31,7 @@ CFLAGS+=-DINET6
>  .endif
>  
>  DPADD=	${LIBGEOM} ${LIBBSDXML} ${LIBSBUF} ${LIBL} ${LIBPTHREAD} ${LIBUTIL}
> -LDADD=	-lgeom -lbsdxml -lsbuf -lpthread -lutil
> +LDADD=	-lgeom -lbsdxml -lsbuf -ll -lpthread -lutil

I think the proper fix is to remove ${LIBL} from DPADD instead. In
r250503 the intention was to remove libl dependency. It looks like I
forgot to update DPADD then.

-- 
Mikolaj Golub