From owner-freebsd-bugs@FreeBSD.ORG  Tue Mar  8 02:10:02 2011
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A7E6F1065674
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  8 Mar 2011 02:10:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 6CBA78FC1B
	for <freebsd-bugs@hub.freebsd.org>;
	Tue,  8 Mar 2011 02:10:02 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p282A1Uf058722
	for <freebsd-bugs@freefall.freebsd.org>; Tue, 8 Mar 2011 02:10:01 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p282A1k8058721;
	Tue, 8 Mar 2011 02:10:01 GMT (envelope-from gnats)
Resent-Date: Tue, 8 Mar 2011 02:10:01 GMT
Resent-Message-Id: <201103080210.p282A1k8058721@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	HIROSHI OOTA <nil@mad.dog.cx>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id B34A2106566C
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue,  8 Mar 2011 02:04:57 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id A35458FC19
	for <freebsd-gnats-submit@FreeBSD.org>;
	Tue,  8 Mar 2011 02:04:57 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p2824vO5006847
	for <freebsd-gnats-submit@FreeBSD.org>; Tue, 8 Mar 2011 02:04:57 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id p2824vH1006846;
	Tue, 8 Mar 2011 02:04:57 GMT (envelope-from nobody)
Message-Id: <201103080204.p2824vH1006846@red.freebsd.org>
Date: Tue, 8 Mar 2011 02:04:57 GMT
From: HIROSHI OOTA <nil@mad.dog.cx>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: misc/155370: description string is broken
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Mar 2011 02:10:02 -0000


>Number:         155370
>Category:       misc
>Synopsis:       description string is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Mar 08 02:10:01 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator:     HIROSHI OOTA
>Release:        9-current
>Organization:
>Environment:
FreeBSD xxxx 9.0-CURRENT FreeBSD 9.0-CURRENT #130 r219237: Fri Mar  4 03:45:57 JST 2011     root@  amd64

>Description:
a description string which is returned from pcap_findalldevs(3) is broken.
>How-To-Repeat:
tcpdump -D
>Fix:


Patch attached with submission follows:

Index: contrib/libpcap/inet.c
===================================================================
--- contrib/libpcap/inet.c	(revision 219237)
+++ contrib/libpcap/inet.c	(working copy)
@@ -432,9 +432,11 @@
 	s = socket(AF_INET, SOCK_DGRAM, 0);
 	if (s >= 0) {
 		for (;;) {
-			free(description);
+			if (description)
+				free(description);
 			if ((description = malloc(descrlen)) != NULL) {
 #ifdef __FreeBSD__
+				description[0] = 0;
 				ifrdesc.ifr_buffer.buffer = description;
 				ifrdesc.ifr_buffer.length = descrlen;
 #else /* __FreeBSD__ */
@@ -467,7 +469,8 @@
 		 */
 		return (-1);
 	}
-	free(description);
+	if (description)
+		free(description);
 	if (curdev == NULL) {
 		/*
 		 * Device wasn't added because it can't be opened.


>Release-Note:
>Audit-Trail:
>Unformatted: