From owner-p4-projects@FreeBSD.ORG  Fri Jun  1 21:49:17 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id BFCA916A46C; Fri,  1 Jun 2007 21:49:16 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 61B7116A468
	for <perforce@freebsd.org>; Fri,  1 Jun 2007 21:49:16 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 5323813C483
	for <perforce@freebsd.org>; Fri,  1 Jun 2007 21:49:16 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l51LnGN9045226
	for <perforce@freebsd.org>; Fri, 1 Jun 2007 21:49:16 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l51LnG4Q045220
	for perforce@freebsd.org; Fri, 1 Jun 2007 21:49:16 GMT
	(envelope-from piso@freebsd.org)
Date: Fri, 1 Jun 2007 21:49:16 GMT
Message-Id: <200706012149.l51LnG4Q045220@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 120730 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Jun 2007 21:49:17 -0000

http://perforce.freebsd.org/chv.cgi?CH=120730

Change 120730 by piso@piso_newluxor on 2007/06/01 21:49:02

	-axe a useless comment
	-clear the interrupt if a filter executed, else mask the src, run
	 the ithread and then clear th src

Affected files ...

.. //depot/projects/soc2006/intr_filter/sparc64/pci/psycho.c#15 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/sparc64/pci/psycho.c#15 (text+ko) ====

@@ -219,7 +219,6 @@
  * providing two PCI buses.
  */
 
-/* XXX let's hope no one ever create a flag with this value... */
 #define FAST    0x66600000 
 
 #ifdef DEBUGGER_ON_POWERFAIL
@@ -990,11 +989,11 @@
 	struct psycho_clr *pc = arg;
 	int res;
 
-	if (pc->pci_filter != NULL)
+	if (pc->pci_filter != NULL) {
 		res = pc->pci_filter(pc->pci_arg);
-	else 
-		res = FILTER_HANDLED | FILTER_SCHEDULE_THREAD;
-	PSYCHO_WRITE8(pc->pci_sc, pc->pci_clr, 0);
+		PSYCHO_WRITE8(pc->pci_sc, pc->pci_clr, 0);
+	} else 
+		res = FILTER_SCHEDULE_THREAD;	
 	return (res);
 }
 
@@ -1009,6 +1008,7 @@
 		(void)PSYCHO_READ8(pc->pci_sc, PSR_DMA_WRITE_SYNC);
 	}
 	pc->pci_handler(pc->pci_arg);
+	PSYCHO_WRITE8(pc->pci_sc, pc->pci_clr, 0);
 }
 
 static int