From nobody Thu Aug 11 09:27:26 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4M3M0L2ZTSz4Ykt4; Thu, 11 Aug 2022 09:27:30 +0000 (UTC) (envelope-from garyj@gmx.de) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mout.gmx.net", Issuer "TeleSec ServerPass Class 2 CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4M3M0K1gmBz3gVS; Thu, 11 Aug 2022 09:27:29 +0000 (UTC) (envelope-from garyj@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660210047; bh=7JxZvRfFlNgX1TVQ/VqSQl/TmaDzPOQ/q0oBOBtcQLM=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:In-Reply-To:References: Reply-To; b=BI3TguOGv7DJ3H8qflT7DyfQGFPaZcHulzOSk4S4oxCh6+zOxdf6K+p8QGIR4kQuB e+8PjtQkYvwMIYJmwzqNjr1TNH6bhceFM/MhFCiZ3Stg3ltuxX3gqhhspufL8s41e5 q3vUwZvaN6pmpBhkchI1IdxBflqXJ3XiUanzCqP8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from ernst.home ([91.2.60.68]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MIdif-1o86MU1Zi9-00EdCy; Thu, 11 Aug 2022 11:27:27 +0200 Date: Thu, 11 Aug 2022 11:27:26 +0200 From: Gary Jennejohn To: "Alexander V. Chernikov" Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 685866bbe13d - main - routing: fix build without ROUTE_MPATH Message-ID: <20220811112726.3fc6eaab@ernst.home> In-Reply-To: <202208102045.27AKjccu054932@gitrepo.freebsd.org> References: <202208102045.27AKjccu054932@gitrepo.freebsd.org> Reply-To: garyj@gmx.de X-Mailer: Claws Mail 3.19.0 (GTK+ 2.24.33; amd64-portbld-freebsd14.0) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:vytBGMY2NNaAUMtn7WanByprQ5L1kA4q9sBBbXfE0z4QKccNoMi TDPipgkShaMPPqyNKQ4xeuKUqqe/5FutsrYwa0GMezJewcUTcOH+h4R1oG2VqrhE4fSvKm9 4ftC3ob9lKhFuM4Ob2AcCGRwSVcdDzjOsBE8oOhzjHTyH/Q8xNpIlI25+Zfo9HXj5H1W2uE KGiJBNcjnsJ9kjqNZpwyQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:f5FCiPOW75k=:05+caUl/6EZqW7hgK/3b+p PjOpn7aOpAAt3y+9DRWyeOogWIAFx/s00sfLTOZ8FTRXCNBjhEjz17edqBXd+kFjExWPaqun1 gw1Cgh3VyhjFI+NCg6RvLtpRn+j6V8piUyyutIggQiCOKiuTV4PUhRmSmXLlYUornMdKBBoTV s4T/w+A+IC1fifWeL6rs6Jq+0aoBGSspKVSqkByJsxhSWeMNOB1YZQlFgenC3MZ6phWLs7o20 gYVSyBckDcLiAOziErh7c3ymiSwgFofRTOTBO5Tfs2hSWNiM6zxzmDldkPqhWgZvyNipCaCED Qetkt3wC94nqCLJoqWTrjTDFd1K5pkpvyURd/L9BU8DrtHIYXptHX+lHKOkeUKHVWjVE+DM9U Dlx1H4VYcgy/frTsbSeK8esysuYz3bhF5ATUlFceB+q1teil0pHJltvo5LEZTVXcDXZ10kfp3 lWMpbKMehRGhhTif72ZG3JuFggYEDfk9rzWbyhOZi0iJPTxg6lGq+nL74aNm+CqgdNKIu4vZI 7XLw6YdAH9FMDzS2J/XGhU7MsIC4y8UtSMm/4T6uyvX0Fu6DTWn3hHB8Dx5T3xhOy2b+FjRO2 hPpecn1sGnzV6lY/ZqQpMkAp5cHU2idirJCYkINc95RPJvPoY/vcYVi08paRK0WqIBfyqVREz Mt2tEY8qvS5g1sBc4qG1p9myBVuasxtn4uiubk4DDYRKxJy0fDbPmCw4xbNlN6aRunqzLAuT8 jwfx6haj2h48nh8emLaYkwCVCZVkQrYiWwUmNT/kydzzxOj+k6D7uZN2M7TNDzc7IyYoWgSPU GJhsCTknno2KzqTUdgIWKLjkDriO733YXYYa7r+iLk56yVfc9i31YZKibIvtnurbmemcZ3VwB dD21KlxuWBgR9IjzlIyCQc1cUqVf75QqVgW8tptsdBNqHcjDakwWzclHbn+0PZDGnEUCwBXTi 5dv/F2X2izGN51TVsV/mJM5GMrs1O5AW84xaRtMLaL3YIVU9Ov+9OUrFySy0bI5PniIOH/U6M yUlYi/vZCfpYbTHGy1VEGlFQ88YEGNsL5pMomLSbRAIAZ8Y9KVE15kujzUQn+xPzFZIe7GnZU I/aqP7IWf3E7IOewvtzGLgww1+W4FRLfGCl X-Rspamd-Queue-Id: 4M3M0K1gmBz3gVS X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmx.net header.s=badeba3b8450 header.b=BI3TguOG; dmarc=pass (policy=none) header.from=gmx.de; spf=pass (mx1.freebsd.org: domain of garyj@gmx.de designates 212.227.17.21 as permitted sender) smtp.mailfrom=garyj@gmx.de X-Spamd-Result: default: False [-3.36 / 15.00]; DWL_DNSWL_LOW(-1.00)[gmx.net:dkim]; NEURAL_HAM_LONG(-0.93)[-0.926]; NEURAL_HAM_SHORT(-0.90)[-0.899]; NEURAL_SPAM_MEDIUM(0.56)[0.564]; DMARC_POLICY_ALLOW(-0.50)[gmx.de,none]; R_DKIM_ALLOW(-0.20)[gmx.net:s=badeba3b8450]; R_SPF_ALLOW(-0.20)[+ip4:212.227.17.0/27]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[212.227.17.21:from]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RWL_MAILSPIKE_POSSIBLE(0.00)[212.227.17.21:from]; FROM_HAS_DN(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-all@FreeBSD.org,dev-commits-src-main@FreeBSD.org]; FREEMAIL_REPLYTO(0.00)[gmx.de]; HAS_REPLYTO(0.00)[garyj@gmx.de]; RCVD_COUNT_TWO(0.00)[2]; FREEMAIL_FROM(0.00)[gmx.de]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[gmx.net:+]; MIME_TRACE(0.00)[0:+]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:8560, ipnet:212.227.0.0/16, country:DE]; FREEMAIL_ENVFROM(0.00)[gmx.de]; RCVD_TLS_ALL(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Wed, 10 Aug 2022 20:45:38 GMT "Alexander V. Chernikov" wrote: > The branch main has been updated by melifaro: > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D685866bbe13da2b9c5d108036= c29f07a4c7cd04f > > commit 685866bbe13da2b9c5d108036c29f07a4c7cd04f > Author: Alexander V. Chernikov > AuthorDate: 2022-08-10 20:44:43 +0000 > Commit: Alexander V. Chernikov > CommitDate: 2022-08-10 20:45:22 +0000 > > routing: fix build without ROUTE_MPATH > > MFC after: 1 month > --- > sys/net/route/route_ctl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sys/net/route/route_ctl.c b/sys/net/route/route_ctl.c > index 8418e8ddd1d5..34b00a0b82ce 100644 > --- a/sys/net/route/route_ctl.c > +++ b/sys/net/route/route_ctl.c > @@ -920,11 +920,11 @@ rt_delete_conditional(struct rib_head *rnh, struct= rtentry *rt, > int prio, rib_filter_f_t *cb, void *cbdata, struct rib_cmd_info *rc= ) > { > struct nhop_object *nh =3D rt->rt_nhop; > - struct route_nhop_data rnd; > > #ifdef ROUTE_MPATH > if (NH_IS_NHGRP(nh)) { > struct nhgrp_object *nhg =3D (struct nhgrp_object *)nh; > + struct route_nhop_data rnd; > int error; > > if (cb =3D=3D NULL) > I did a buildkernel and got this warning message: /usr/src/sys/net/route/route_ctl.c:787:1: warning: unused function 'add_ro= ute_flags_mpath' [-Wunused-function] add_route_flags_mpath(struct rib_head *rnh, struct rtentry *rt, ^ 1 warning generated. This is because the function is only called if ROUTE_MPATH is defined, but the forward declaration and implementation of add_route_flags_mpath are not gated with #ifdef ROUTE_MPATH. =2D- Gary Jennejohn