From owner-svn-src-all@freebsd.org Tue Aug 18 09:06:54 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E22573B5010 for ; Tue, 18 Aug 2020 09:06:54 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from vito-vars.onthenet.com.au (vito-vars.OntheNet.com.au [203.13.68.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BW4mG0ndqz3V1L for ; Tue, 18 Aug 2020 09:06:54 +0000 (UTC) (envelope-from grehan@freebsd.org) Received: from alto.onthenet.com.au (alto2.onthenet.com.au [203.13.68.14]) by vito-vars.onthenet.com.au (Postfix) with ESMTPS id BCECD2094E44 for ; Tue, 18 Aug 2020 19:06:47 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [203.13.68.150]) by alto.onthenet.com.au (Postfix) with ESMTPS id A6CE220AE981 for ; Tue, 18 Aug 2020 19:06:47 +1000 (AEST) Received: from iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) by iredmail.onthenet.com.au (Postfix) with ESMTP id 95DFE20E4665 for ; Tue, 18 Aug 2020 19:06:47 +1000 (AEST) Received: from iredmail.onthenet.com.au ([127.0.0.1]) by iredmail.onthenet.com.au (iredmail.onthenet.com.au [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id AKO8mh6f_H3L for ; Tue, 18 Aug 2020 19:06:47 +1000 (AEST) Received: from MacBook-Air-4.local (CPE-120-29-42-110.dsl.OntheNet.net [120.29.42.110]) by iredmail.onthenet.com.au (Postfix) with ESMTPSA id 3425720DC2D4; Tue, 18 Aug 2020 19:06:46 +1000 (AEST) Subject: Re: svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202008180723.07I7NlVq046197@repo.freebsd.org> <20200818084819.GN2551@kib.kiev.ua> From: Peter Grehan Message-ID: Date: Tue, 18 Aug 2020 19:06:45 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200818084819.GN2551@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=bM+N3M2Z c=1 sm=1 tr=0 a=A6CF0fG5TOl4vs6YHvqXgw==:117 a=jXL/WSj5nX36MkVNSbrI6Q==:17 a=IkcTkHD0fZMA:10 a=y4yBn9ojGxQA:10 a=nWEQlCDuWIA7WGBD6YAA:9 a=QEXdDO2ut3YA:10 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=LtAJNkVc c=1 sm=1 tr=0 a=eF5wA05EhuPcU0j7PNT2Vg==:117 a=jXL/WSj5nX36MkVNSbrI6Q==:17 a=IkcTkHD0fZMA:10 a=y4yBn9ojGxQA:10 a=nWEQlCDuWIA7WGBD6YAA:9 a=QEXdDO2ut3YA:10 X-Rspamd-Queue-Id: 4BW4mG0ndqz3V1L X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [0.00 / 15.00]; ASN(0.00)[asn:9313, ipnet:203.13.68.0/23, country:AU]; local_wl_from(0.00)[freebsd.org] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Aug 2020 09:06:54 -0000 On 8/18/20 6:48 PM, Konstantin Belousov wrote: > On Tue, Aug 18, 2020 at 07:23:47AM +0000, Peter Grehan wrote: >> +void >> +vmx_msr_guest_exit_tsc_aux(struct vmx *vmx, int vcpuid) >> +{ >> + uint64_t guest_tsc_aux = vmx->guest_msrs[vcpuid][IDX_MSR_TSC_AUX]; >> + uint32_t cpuid = PCPU_GET(cpuid); >> + >> + if (vmx_have_msr_tsc_aux(vmx) && (guest_tsc_aux != cpuid)) > This is quite unobvious place to look at if host TSC_AUX is ever going > to provide something different from cpuid. > > Could you please add a comment at > {i386/i386, No bhyve on i386. > amd64/amd64}/initcpu.c::initializecpu() around TSC_AUX > settings pointing out this code ? Sure, will do. later, Peter.