Date: Tue, 18 Aug 2020 19:06:45 +1000 From: Peter Grehan <grehan@freebsd.org> To: Konstantin Belousov <kostikbel@gmail.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r364340 - in head/sys/amd64: include vmm vmm/intel Message-ID: <d4e2165d-ec2d-d7ac-1cba-4ba7464ea44b@freebsd.org> In-Reply-To: <20200818084819.GN2551@kib.kiev.ua> References: <202008180723.07I7NlVq046197@repo.freebsd.org> <20200818084819.GN2551@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On 8/18/20 6:48 PM, Konstantin Belousov wrote:
> On Tue, Aug 18, 2020 at 07:23:47AM +0000, Peter Grehan wrote:
>> +void
>> +vmx_msr_guest_exit_tsc_aux(struct vmx *vmx, int vcpuid)
>> +{
>> + uint64_t guest_tsc_aux = vmx->guest_msrs[vcpuid][IDX_MSR_TSC_AUX];
>> + uint32_t cpuid = PCPU_GET(cpuid);
>> +
>> + if (vmx_have_msr_tsc_aux(vmx) && (guest_tsc_aux != cpuid))
> This is quite unobvious place to look at if host TSC_AUX is ever going
> to provide something different from cpuid.
>
> Could you please add a comment at
> {i386/i386,
No bhyve on i386.
> amd64/amd64}/initcpu.c::initializecpu() around TSC_AUX
> settings pointing out this code ?
Sure, will do.
later,
Peter.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d4e2165d-ec2d-d7ac-1cba-4ba7464ea44b>