From owner-svn-src-all@FreeBSD.ORG  Thu Apr 15 05:56:28 2010
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 3A280106564A;
	Thu, 15 Apr 2010 05:56:28 +0000 (UTC) (envelope-from avg@freebsd.org)
Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140])
	by mx1.freebsd.org (Postfix) with ESMTP id 8C3678FC15;
	Thu, 15 Apr 2010 05:56:25 +0000 (UTC)
Received: from porto.topspin.kiev.ua (porto-e.starpoint.kiev.ua
	[212.40.38.100])
	by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id IAA18330;
	Thu, 15 Apr 2010 08:56:24 +0300 (EEST)
	(envelope-from avg@freebsd.org)
Received: from localhost.topspin.kiev.ua ([127.0.0.1])
	by porto.topspin.kiev.ua with esmtp (Exim 4.34 (FreeBSD))
	id 1O2I3r-0004kw-NO; Thu, 15 Apr 2010 08:56:23 +0300
Message-ID: <4BC6AA87.40309@freebsd.org>
Date: Thu, 15 Apr 2010 08:56:23 +0300
From: Andriy Gapon <avg@freebsd.org>
User-Agent: Thunderbird 2.0.0.24 (X11/20100321)
MIME-Version: 1.0
To: Xin LI <delphij@freebsd.org>
References: <201004150120.o3F1KUPt043636@svn.freebsd.org>
In-Reply-To: <201004150120.o3F1KUPt043636@svn.freebsd.org>
X-Enigmail-Version: 0.96.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, svn-src-stable-8@freebsd.org
Subject: Re: svn commit: r206640 - in stable/8/cddl/contrib/opensolaris:
 cmd/zfs lib/libzfs/common
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Apr 2010 05:56:28 -0000

on 15/04/2010 04:20 Xin LI said the following:
> Author: delphij
> Date: Thu Apr 15 01:20:30 2010
> New Revision: 206640
> URL: http://svn.freebsd.org/changeset/base/206640
> 
> Log:
>   MFC r205198:
>   
>   Merge OpenSolaris revision 8802:010b31dd4c53:
>   
>   6773366 "zfs list" memory consumption can be further reduced
>   
>   PR:		bin/144720
>   Submitted by:	mm


I wonder why you haven't also included into this MFC the commit that fixes crash
with user properties.
I think it's not nice to MFC a change with a known bug without a fix.


> +	while (curr) {
> +		zfs_prop_t zfs_prop = zfs_name_to_prop(nvpair_name(curr));
> +		nvpair_t *next = nvlist_next_nvpair(zhp->zfs_props, curr);
> +
> +		if (props[zfs_prop] == B_FALSE)

zfs_prop can be -1 here, remember?

-- 
Andriy Gapon