From owner-p4-projects  Tue Jun 25  9:15:32 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4052C37B401; Tue, 25 Jun 2002 09:15:21 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mail.speakeasy.net (mail12.speakeasy.net [216.254.0.212])
	by hub.freebsd.org (Postfix) with ESMTP id 711DE37B404
	for <perforce@freebsd.org>; Tue, 25 Jun 2002 09:15:19 -0700 (PDT)
Received: (qmail 14838 invoked from network); 25 Jun 2002 15:11:03 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
          (envelope-sender <jhb@FreeBSD.org>)
          by mail12.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP
          for <perforce@freebsd.org>; 25 Jun 2002 15:11:04 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.11.6/8.11.6) with ESMTP id g5PFB2b38555;
	Tue, 25 Jun 2002 11:11:02 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20020625111105.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.2 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200206180725.g5I7PCQ51323@freefall.freebsd.org>
Date: Tue, 25 Jun 2002 11:11:05 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Julian Elischer <julian@FreeBSD.org>
Subject: RE: PERFORCE change 13103 for review
Cc: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG


On 18-Jun-2002 Julian Elischer wrote:
> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=13103
> 
> Change 13103 by julian@julian_ref on 2002/06/18 00:24:27
> 
>       Start cleaning up the mess I made when I changed APIs.
>       still doesn't quite work, but I've tracked down a lot of brainos
>       including a couple I haven't fixed yet.
> 
> Affected files ...
> 
> ... //depot/projects/kse/sys/alpha/alpha/trap.c#26 edit
> ... //depot/projects/kse/sys/i386/i386/swtch.s#34 edit
> ... //depot/projects/kse/sys/i386/i386/trap.c#51 edit
> ... //depot/projects/kse/sys/i386/i386/vm_machdep.c#57 edit
> ... //depot/projects/kse/sys/kern/init_main.c#42 edit
> ... //depot/projects/kse/sys/kern/kern_exit.c#54 edit
> ... //depot/projects/kse/sys/kern/kern_fork.c#70 edit
> ... //depot/projects/kse/sys/kern/kern_proc.c#70 edit
> ... //depot/projects/kse/sys/kern/kern_thread.c#70 edit
> ... //depot/projects/kse/sys/sparc64/sparc64/trap.c#30 edit
> 
> Differences ...
> 
> ==== //depot/projects/kse/sys/alpha/alpha/trap.c#26 (text+ko) ====
> 
> @@ -301,6 +301,7 @@
>               if (td->td_ucred != p->p_ucred)
>                       cred_update_thread(td);
>               if ((p->p_flag & P_WEXIT) && (p->p_singlethread != td)) {
> +                     mtx_lock_spin(&sched_lock);
>                       PROC_LOCK(p);
>                       thread_exit();
>                       /* NOTREACHED */

Can't do this.  (Acquire spin lock before a sleep mutex.)


>                * First check that we shouldn't just abort.
> -              * But check if the are the single thread first!
> +              * But check if we are the single thread first!
>                */
>               if ((p->p_flag & P_WEXIT) && (p->p_singlethread != td)) {
> +                     mtx_lock_spin(&sched_lock);
>                       PROC_LOCK(p);
>                       thread_exit();
>                       /* NOTREACHED */

Same here.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message