Date: Mon, 15 Feb 2016 01:58:22 +0000 From: "sepherosa_gmail.com (Sepherosa Ziehau)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Request, 4 lines] D5282: hyperv/hn: Use non-fast taskqueue for transmission Message-ID: <differential-rev-PHID-DREV-rcg32bmt76bmox5gxiaa-req@FreeBSD.org>
next in thread | raw e-mail | index | archive | help
--b1_dbf02bd8d30638fbe43e32f705f90573 Content-Type: text/plain; charset = "utf-8" Content-Transfer-Encoding: 8bit sepherosa_gmail.com created this revision. sepherosa_gmail.com added reviewers: network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com. sepherosa_gmail.com added subscribers: freebsd-net-list, freebsd-virtualization-list. REVISION SUMMARY Performance stays same; so no need to use fast taskqueue here. REVISION DETAIL https://reviews.freebsd.org/D5282 AFFECTED FILES sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c CHANGE DETAILS diff --git a/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c b/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c --- a/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c +++ b/sys/dev/hyperv/netvsc/hv_netvsc_drv_freebsd.c @@ -368,7 +368,7 @@ sc->hn_direct_tx_size = hn_direct_tx_size; if (hn_tx_taskq == NULL) { - sc->hn_tx_taskq = taskqueue_create_fast("hn_tx", M_WAITOK, + sc->hn_tx_taskq = taskqueue_create("hn_tx", M_WAITOK, taskqueue_thread_enqueue, &sc->hn_tx_taskq); taskqueue_start_threads(&sc->hn_tx_taskq, 1, PI_NET, "%s tx", device_get_nameunit(dev)); @@ -2178,7 +2178,7 @@ if (!hn_share_tx_taskq) return; - hn_tx_taskq = taskqueue_create_fast("hn_tx", M_WAITOK, + hn_tx_taskq = taskqueue_create("hn_tx", M_WAITOK, taskqueue_thread_enqueue, &hn_tx_taskq); taskqueue_start_threads(&hn_tx_taskq, 1, PI_NET, "hn tx"); } EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, adrian, delphij, royger, decui_microsoft.com, honzhan_microsoft.com, howard0su_gmail.com Cc: freebsd-virtualization-list, freebsd-net-list --b1_dbf02bd8d30638fbe43e32f705f90573 Content-Type: text/x-patch; charset=utf-8; name="D5282.13307.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="D5282.13307.patch" ZGlmZiAtLWdpdCBhL3N5cy9kZXYvaHlwZXJ2L25ldHZzYy9odl9uZXR2c2NfZHJ2X2ZyZWVic2Qu YyBiL3N5cy9kZXYvaHlwZXJ2L25ldHZzYy9odl9uZXR2c2NfZHJ2X2ZyZWVic2QuYwotLS0gYS9z eXMvZGV2L2h5cGVydi9uZXR2c2MvaHZfbmV0dnNjX2Rydl9mcmVlYnNkLmMKKysrIGIvc3lzL2Rl di9oeXBlcnYvbmV0dnNjL2h2X25ldHZzY19kcnZfZnJlZWJzZC5jCkBAIC0zNjgsNyArMzY4LDcg QEAKIAlzYy0+aG5fZGlyZWN0X3R4X3NpemUgPSBobl9kaXJlY3RfdHhfc2l6ZTsKIAogCWlmICho bl90eF90YXNrcSA9PSBOVUxMKSB7Ci0JCXNjLT5obl90eF90YXNrcSA9IHRhc2txdWV1ZV9jcmVh dGVfZmFzdCgiaG5fdHgiLCBNX1dBSVRPSywKKwkJc2MtPmhuX3R4X3Rhc2txID0gdGFza3F1ZXVl X2NyZWF0ZSgiaG5fdHgiLCBNX1dBSVRPSywKIAkJICAgIHRhc2txdWV1ZV90aHJlYWRfZW5xdWV1 ZSwgJnNjLT5obl90eF90YXNrcSk7CiAJCXRhc2txdWV1ZV9zdGFydF90aHJlYWRzKCZzYy0+aG5f dHhfdGFza3EsIDEsIFBJX05FVCwgIiVzIHR4IiwKIAkJICAgIGRldmljZV9nZXRfbmFtZXVuaXQo ZGV2KSk7CkBAIC0yMTc4LDcgKzIxNzgsNyBAQAogCWlmICghaG5fc2hhcmVfdHhfdGFza3EpCiAJ CXJldHVybjsKIAotCWhuX3R4X3Rhc2txID0gdGFza3F1ZXVlX2NyZWF0ZV9mYXN0KCJobl90eCIs IE1fV0FJVE9LLAorCWhuX3R4X3Rhc2txID0gdGFza3F1ZXVlX2NyZWF0ZSgiaG5fdHgiLCBNX1dB SVRPSywKIAkgICAgdGFza3F1ZXVlX3RocmVhZF9lbnF1ZXVlLCAmaG5fdHhfdGFza3EpOwogCXRh c2txdWV1ZV9zdGFydF90aHJlYWRzKCZobl90eF90YXNrcSwgMSwgUElfTkVULCAiaG4gdHgiKTsK IH0KCg== --b1_dbf02bd8d30638fbe43e32f705f90573--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?differential-rev-PHID-DREV-rcg32bmt76bmox5gxiaa-req>