From owner-cvs-all@FreeBSD.ORG Tue Mar 18 21:27:12 2008 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E29A106566C; Tue, 18 Mar 2008 21:27:12 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from cpanel03.rubas-s03.net (cpanel03.rubas-s03.net [195.182.222.73]) by mx1.freebsd.org (Postfix) with ESMTP id 312E88FC1A; Tue, 18 Mar 2008 21:27:12 +0000 (UTC) (envelope-from gahr@FreeBSD.org) Received: from doc175-eva98.evard.ch ([213.142.175.98] helo=gahrtop.localhost) by cpanel03.rubas-s03.net with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.68) (envelope-from ) id 1Jbhae-0004Xs-Kh; Tue, 18 Mar 2008 20:35:16 +0100 Message-ID: <47E01971.4080506@FreeBSD.org> Date: Tue, 18 Mar 2008 20:35:13 +0100 From: Pietro Cerutti Organization: The FreeBSD Project User-Agent: Thunderbird 2.0.0.12 (X11/20080311) MIME-Version: 1.0 To: Alexey Dokuchaev References: <200803180100.m2I10QTD070047@repoman.freebsd.org> <20080318193855.0439b197.stas@FreeBSD.org> <20080318181546.GA10903@FreeBSD.org> In-Reply-To: <20080318181546.GA10903@FreeBSD.org> X-Enigmail-Version: 0.95.6 OpenPGP: id=9571F78E; url=http://gahr.ch/pgp/ Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel03.rubas-s03.net X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - FreeBSD.org X-Source: X-Source-Args: X-Source-Dir: Cc: Stanislav Sedov , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/java/eclipseme Makefile distinfo pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Mar 2008 21:27:12 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Alexey Dokuchaev wrote: | On Tue, Mar 18, 2008 at 07:38:55PM +0300, Stanislav Sedov wrote: |> On Tue, 18 Mar 2008 01:00:26 +0000 (UTC) |> Pietro Cerutti mentioned: |> |>> gahr 2008-03-18 01:00:26 UTC |>> |>> FreeBSD ports repository |>> |>> Modified files: |>> java/eclipseme Makefile distinfo pkg-plist |>> Log: |>> - Update to 0.4.6 |>> |>> Approved by: miwi (mentor) |>> |>> Revision Changes Path |>> 1.6 +5 -8 ports/java/eclipseme/Makefile |>> http://cvsweb.FreeBSD.org/ports/java/eclipseme/Makefile.diff?r1=1.5&r2=1.6 |>> | --- ports/java/eclipseme/Makefile 2007/07/16 08:58:28 1.5 |>> | +++ ports/java/eclipseme/Makefile 2008/03/18 01:00:25 1.6 |>> | @@ -2,15 +2,13 @@ |>> | # Date created: July 22, 2004 |>> | # Whom: past@ebs.gr |>> | # |>> | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/java/eclipseme/Makefile,v 1.5 2007/07/16 08:58:28 pav Exp $ |>> | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/java/eclipseme/Makefile,v 1.6 2008/03/18 01:00:25 gahr Exp $ |>> | # |>> | |>> | PORTNAME= eclipseme |>> | -PORTVERSION= 0.4.5 |>> | -PORTREVISION= 3 |>> | +PORTVERSION= 0.4.6 |>> | CATEGORIES= java devel |>> | -MASTER_SITES= ${MASTER_SITE_SOURCEFORGE} |>> | -MASTER_SITE_SUBDIR= ${PORTNAME} |>> | +MASTER_SITES= SF |>> | DISTNAME= ${PORTNAME}-${PORTVERSION} |>> | DIST_SUBDIR= eclipse |>> | |>> | @@ -31,11 +29,10 @@ RUN_DEPENDS+= ${LOCALBASE}/share/proguar |>> | .endif |>> | |>> | do-install: |>> | - @${CP} -r ${WRKSRC}/${PORTNAME}_${PORTVERSION} ${PREFIX}/eclipse/plugins/ |>> | + @${MKDIR} ${PREFIX}/eclipse/plugins |>> | + @${CP} -r ${WRKSRC}/${PORTNAME}_${PORTVERSION} ${PREFIX}/eclipse/plugins/ |> Wouldn't it be better to use COPYTREE_SHARE for that? This way it'll set correct |> permissions on files. | | Not to mention that -R should've probably be used instead or -r, and we | generally try not to mute installation of files/links (as opposed to | dirs). | | ./danfe Agreed. I will fix the -r option and switch to COPYTREE_SHARE. Thanks! - -- Pietro Cerutti gahr@FreeBSD.org PGP Public Key: http://gahr.ch/pgp -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.8 (FreeBSD) iEYEAREKAAYFAkfgGXAACgkQwMJqmJVx944A1QCfW9uODmUgyndez4WfIOd0ST+s cDoAoL1yjEU76+HRnLlOm1tJOXAD67Xt =Du/q -----END PGP SIGNATURE-----