From owner-svn-src-head@FreeBSD.ORG  Sat Nov 22 16:03:19 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 277BE106564A;
	Sat, 22 Nov 2008 16:03:19 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c])
	by mx1.freebsd.org (Postfix) with ESMTP id 109C58FC0A;
	Sat, 22 Nov 2008 16:03:19 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from svn.freebsd.org (localhost [127.0.0.1])
	by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id mAMG3IwT022242;
	Sat, 22 Nov 2008 16:03:18 GMT (envelope-from mav@svn.freebsd.org)
Received: (from mav@localhost)
	by svn.freebsd.org (8.14.3/8.14.3/Submit) id mAMG3I1e022241;
	Sat, 22 Nov 2008 16:03:18 GMT (envelope-from mav@svn.freebsd.org)
Message-Id: <200811221603.mAMG3I1e022241@svn.freebsd.org>
From: Alexander Motin <mav@FreeBSD.org>
Date: Sat, 22 Nov 2008 16:03:18 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
	svn-src-head@freebsd.org
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Cc: 
Subject: svn commit: r185179 - head/sys/netgraph
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Nov 2008 16:03:19 -0000

Author: mav
Date: Sat Nov 22 16:03:18 2008
New Revision: 185179
URL: http://svn.freebsd.org/changeset/base/185179

Log:
  Remove unneeded NULL check. At first msg can't be null here and and at second
  NG_FREE_MSG() also checks it.
  
  Found with:	Coverity Prevent(tm)

Modified:
  head/sys/netgraph/ng_base.c

Modified: head/sys/netgraph/ng_base.c
==============================================================================
--- head/sys/netgraph/ng_base.c	Sat Nov 22 15:38:24 2008	(r185178)
+++ head/sys/netgraph/ng_base.c	Sat Nov 22 16:03:18 2008	(r185179)
@@ -2853,8 +2853,7 @@ ng_generic_msg(node_p here, item_p item,
 	 */
 out:
 	NG_RESPOND_MSG(error, here, item, resp);
-	if (msg)
-		NG_FREE_MSG(msg);
+	NG_FREE_MSG(msg);
 	return (error);
 }