Date: Wed, 6 Jun 2012 08:32:54 -0600 From: Warner Losh <imp@bsdimp.com> To: Garrett Cooper <yanegomi@gmail.com> Cc: arm@FreeBSD.org Subject: Re: [head tinderbox] failure on arm/arm Message-ID: <5B91D416-FE5B-417D-A1C3-9388C8A5F575@bsdimp.com> In-Reply-To: <CAGH67wTNJ9_GqjzQ_XWbkp%2BUhXXNxhNMFXP%2B9iE%2B_T7dDeivxA@mail.gmail.com> References: <201206061321.q56DLA7L013817@freebsd-current.sentex.ca> <CAGH67wTNJ9_GqjzQ_XWbkp%2BUhXXNxhNMFXP%2B9iE%2B_T7dDeivxA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Thanks Garrett!
I switched from a switch to an if due to changes at the last minute, and =
didn't test somehow (too many kernels to compile for complete coverage, =
but I'm working to fix that :). Sorry for the hassle.
Warner
On Jun 6, 2012, at 7:39 AM, Garrett Cooper wrote:
> ...
>=20
> cc -mlittle-endian -c -O2 -pipe -fno-strict-aliasing -std=3Dc99 =
-Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef
> -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs
> -fdiagnostics-show-option -nostdinc -I. -I/src/sys
> -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL
> -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
> -finline-limit=3D8000 --param inline-unit-growth=3D100 --param
> large-function-growth=3D1000 -mcpu=3Darm9 -mno-apcs-frame =
-ffreestanding
> -Werror /src/sys/arm/at91/at91sam9260.c
> /src/sys/arm/at91/at91sam9260.c: In function 'at91_identify':
> /src/sys/arm/at91/at91sam9260.c:203: error: break statement not within
> loop or switch
> *** Error code 1
>=20
> Stop in /obj/arm.arm/src/sys/ETHERNUT5.
> *** Error code 1
>=20
> Stop in /src.
> *** Error code 1
>=20
> Stop in /src.
> TB --- 2012-06-06 13:21:10 - WARNING: /usr/bin/make returned exit code =
1
> TB --- 2012-06-06 13:21:10 - ERROR: failed to build ETHERNUT5 kernel
> TB --- 2012-06-06 13:21:10 - 3927.58 user 801.22 system 6069.07 real
>=20
> This simple patch will unbreak arm tinderbox.
> Thanks!
> -Garrett
>=20
> Index: sys/arm/at91/at91sam9260.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sys/arm/at91/at91sam9260.c (revision 236680)
> +++ sys/arm/at91/at91sam9260.c (working copy)
> @@ -200,7 +200,6 @@
> if (soc_data.type =3D=3D AT91_CPU_SAM9260) {
> at91_add_child(parent, 0, "at91sam9260", 0, 0, 0, -1, =
0, 0);
> at91_cpu_add_builtin_children(parent);
> - break;
> }
> }
>=20
>=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5B91D416-FE5B-417D-A1C3-9388C8A5F575>