From owner-freebsd-arm@FreeBSD.ORG  Wed Jun  6 14:38:19 2012
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: arm@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id B93BE1065674
	for <arm@FreeBSD.org>; Wed,  6 Jun 2012 14:38:19 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 56A028FC1C
	for <arm@FreeBSD.org>; Wed,  6 Jun 2012 14:38:19 +0000 (UTC)
Received: from 63.imp.bsdimp.com (63.imp.bsdimp.com [10.0.0.63])
	(authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id q56EWsSd033589
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Wed, 6 Jun 2012 08:32:55 -0600 (MDT) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <CAGH67wTNJ9_GqjzQ_XWbkp+UhXXNxhNMFXP+9iE+_T7dDeivxA@mail.gmail.com>
Date: Wed, 6 Jun 2012 08:32:54 -0600
Content-Transfer-Encoding: quoted-printable
Message-Id: <5B91D416-FE5B-417D-A1C3-9388C8A5F575@bsdimp.com>
References: <201206061321.q56DLA7L013817@freebsd-current.sentex.ca>
	<CAGH67wTNJ9_GqjzQ_XWbkp+UhXXNxhNMFXP+9iE+_T7dDeivxA@mail.gmail.com>
To: Garrett Cooper <yanegomi@gmail.com>
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Wed, 06 Jun 2012 08:32:55 -0600 (MDT)
Cc: arm@FreeBSD.org
Subject: Re: [head tinderbox] failure on arm/arm
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Jun 2012 14:38:19 -0000

Thanks Garrett!

I switched from a switch to an if due to changes at the last minute, and =
didn't test somehow (too many kernels to compile for complete coverage, =
but I'm working to fix that :).  Sorry for the hassle.

Warner

On Jun 6, 2012, at 7:39 AM, Garrett Cooper wrote:

> ...
>=20
> cc -mlittle-endian -c -O2 -pipe -fno-strict-aliasing  -std=3Dc99  =
-Wall
> -Wredundant-decls -Wnested-externs -Wstrict-prototypes
> -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef
> -Wno-pointer-sign -fformat-extensions  -Wmissing-include-dirs
> -fdiagnostics-show-option   -nostdinc  -I. -I/src/sys
> -I/src/sys/contrib/altq -I/src/sys/contrib/libfdt -D_KERNEL
> -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common
> -finline-limit=3D8000 --param inline-unit-growth=3D100 --param
> large-function-growth=3D1000 -mcpu=3Darm9 -mno-apcs-frame =
-ffreestanding
> -Werror  /src/sys/arm/at91/at91sam9260.c
> /src/sys/arm/at91/at91sam9260.c: In function 'at91_identify':
> /src/sys/arm/at91/at91sam9260.c:203: error: break statement not within
> loop or switch
> *** Error code 1
>=20
> Stop in /obj/arm.arm/src/sys/ETHERNUT5.
> *** Error code 1
>=20
> Stop in /src.
> *** Error code 1
>=20
> Stop in /src.
> TB --- 2012-06-06 13:21:10 - WARNING: /usr/bin/make returned exit code =
 1
> TB --- 2012-06-06 13:21:10 - ERROR: failed to build ETHERNUT5 kernel
> TB --- 2012-06-06 13:21:10 - 3927.58 user 801.22 system 6069.07 real
>=20
>    This simple patch will unbreak arm tinderbox.
> Thanks!
> -Garrett
>=20
> Index: sys/arm/at91/at91sam9260.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- sys/arm/at91/at91sam9260.c   (revision 236680)
> +++ sys/arm/at91/at91sam9260.c   (working copy)
> @@ -200,7 +200,6 @@
>        if (soc_data.type =3D=3D AT91_CPU_SAM9260) {
>                at91_add_child(parent, 0, "at91sam9260", 0, 0, 0, -1, =
0, 0);
>                at91_cpu_add_builtin_children(parent);
> -               break;
>        }
> }
>=20
>=20